Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp

Issue 2181243002: Move ThreadableLoader to Oilpan heap (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
index 5db39ffe8e3d59fbb93810e9cc8ef3e17d92d972..11474211176240b3c233b5234a2859f7940eb18a 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
@@ -76,7 +76,7 @@ public:
m_updater->update(createUnexpectedErrorDataConsumerHandle());
if (m_loader) {
m_loader->cancel();
- m_loader.reset();
+ m_loader = nullptr;
}
}
@@ -103,7 +103,7 @@ public:
}
private:
- std::unique_ptr<ThreadableLoader> createLoader(ExecutionContext* executionContext, ThreadableLoaderClient* client) const
+ ThreadableLoader* createLoader(ExecutionContext* executionContext, ThreadableLoaderClient* client) const
{
ThreadableLoaderOptions options;
options.preflightPolicy = ConsiderPreflight;
@@ -134,14 +134,14 @@ private:
void didFinishLoading(unsigned long, double) override
{
- m_loader.reset();
+ m_loader = nullptr;
}
void didFail(const ResourceError&) override
{
if (!m_receivedResponse)
m_updater->update(createUnexpectedErrorDataConsumerHandle());
- m_loader.reset();
+ m_loader = nullptr;
}
void didFailRedirectCheck() override
@@ -154,14 +154,14 @@ private:
RefPtr<BlobDataHandle> m_blobDataHandle;
Persistent<FetchBlobDataConsumerHandle::LoaderFactory> m_loaderFactory;
- std::unique_ptr<ThreadableLoader> m_loader;
+ Persistent<ThreadableLoader> m_loader;
bool m_receivedResponse;
};
class DefaultLoaderFactory final : public FetchBlobDataConsumerHandle::LoaderFactory {
public:
- std::unique_ptr<ThreadableLoader> create(
+ ThreadableLoader* create(
ExecutionContext& executionContext,
ThreadableLoaderClient* client,
const ThreadableLoaderOptions& options,

Powered by Google App Engine
This is Rietveld 408576698