Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2180803002: Converted Observatory vm-connect element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Removed temporary commented code Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 7f51a8ea2f0253d13b970f7048151736e327d7cf..88ba1ee8bbe1dd0a016356f53344854d0b18e641 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -18,7 +18,7 @@ abstract class Page extends Observable {
final ObservatoryApplication app;
final ObservableMap<String, String> internalArguments =
new ObservableMap<String, String>();
- @observable ObservatoryElement element;
+ @observable HtmlElement element;
Page(this.app);
@@ -370,7 +370,11 @@ class VMConnectPage extends Page {
void onInstall() {
if (element == null) {
- element = new Element.tag('vm-connect');
+ element = new VMConnectElement(
+ ObservatoryApplication.app.targets,
+ new DumpRepositoryMock(ObservatoryApplication.app.loadCrashDump),
+ ObservatoryApplication.app.notifications,
+ queue: ObservatoryApplication.app.queue);
}
assert(element != null);
}

Powered by Google App Engine
This is Rietveld 408576698