Converted Observatory source-link & script-ref elements

Converted Observatory source-link & script-ref elements

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/445180ad4179029f32f32d2f0645a40b7ec3cebd

[cbernaschina, 2016-07-22 20:44:22]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[Cutch, 2016-07-25 14:08:21]

https://codereview.chromium.org/2180553002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/field_view.html (right):

https://codereview.chromium.org/2180553002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/field_view.html:8: =======
bad merge

https://codereview.chromium.org/2180553002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/isolate_summary.html (right):

https://codereview.chromium.org/2180553002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/isolate_summary.html:6: <link rel="import"
href="script_inset.html">
ditto

[cbernaschina, 2016-07-25 15:57:13]

https://codereview.chromium.org/2180553002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/field_view.html (right):

https://codereview.chromium.org/2180553002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/field_view.html:8: =======
On 2016/07/25 14:08:21, Cutch wrote:
> bad merge

Done.

https://codereview.chromium.org/2180553002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/isolate_summary.html (right):

https://codereview.chromium.org/2180553002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/isolate_summary.html:6: <link rel="import"
href="script_inset.html">
On 2016/07/25 14:08:21, Cutch wrote:
> ditto 

Done.

[Cutch, 2016-07-25 20:29:42]

https://codereview.chromium.org/2180553002/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/script_ref.dart (right):

https://codereview.chromium.org/2180553002/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_ref.dart:28: factory
ScriptRefElement(M.IsolateRef isolate, M.ScriptRef script,
what happened to the ---pos= parameter?

[cbernaschina, 2016-07-25 20:44:37]

https://codereview.chromium.org/2180553002/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/script_ref.dart (right):

https://codereview.chromium.org/2180553002/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/script_ref.dart:28: factory
ScriptRefElement(M.IsolateRef isolate, M.ScriptRef script,
On 2016/07/25 20:29:42, Cutch wrote:
> what happened to the ---pos= parameter?

script-ref had an optional pos parameter that was just used by source-link.

Due to the fact that the view is just a single link I've separated the two
components.
script-ref manages just links to Script objects
source-link manages the pair <Script . Token>

[Cutch, 2016-07-25 22:33:54]

Todd should probably review this one.

[rmacnak, 2016-07-26 17:51:52]

https://chromiumcodereview.appspot.com/2180553002/diff/60001/runtime/observat...
File runtime/observatory/observatory_sources.gypi (right):

https://chromiumcodereview.appspot.com/2180553002/diff/60001/runtime/observat...
runtime/observatory/observatory_sources.gypi:162:
'lib/src/elements/script_ref.html',
Deleted.

[cbernaschina, 2016-07-26 18:30:10]

https://chromiumcodereview.appspot.com/2180553002/diff/60001/runtime/observat...
File runtime/observatory/observatory_sources.gypi (right):

https://chromiumcodereview.appspot.com/2180553002/diff/60001/runtime/observat...
runtime/observatory/observatory_sources.gypi:162:
'lib/src/elements/script_ref.html',
On 2016/07/26 17:51:52, rmacnak wrote:
> Deleted.

Done.

[turnidge, 2016-07-28 17:15:56]

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/script_ref.dart (right):

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/script_ref.dart:14: class ScriptRefElement
extends HtmlElement implements Renderable{
Add a space in "Renderable{"

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/script_ref.dart:59: ..text =
script.uri.split('/').last
Could this be script.uri.pathSegments.last to avoid the call to split?

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/source_link.dart (right):

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:1: // Copyright (c) 2013,
the Dart project authors.  Please see the AUTHORS file
Update date here and in all other files you are adding: 2016.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:15: class
SourceLinkElement extends HtmlElement implements Renderable{
Add space between Renderable and {.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:21: 
Remove extra blank line.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:32: ScriptRepository
repository, {RenderingQueue queue}) {
Fix indentation.  One parameter per line?

Maybe try running this through the dart formatter.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:57: void detached() {
super.detached(); children = []; _r.disable(notify: true); }
Can this detached/RenderingScheduler/onRendered boilerplate be shared somehow? 
Maybe a mixin?  How about the attached?  Is there a way to share some of this
code across elements?

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:63: String label =
_script.uri.split('/').last;
pathSegments

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/source_link_wrapper.dart (right):

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link_wrapper.dart:1: // Copyright
(c) 2013, the Dart project authors.  Please see the AUTHORS file
2016, you get the idea.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/mocks/objects/script.dart (right):

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/mocks/objects/script.dart:27: 
Remove extra blank line here.

[cbernaschina, 2016-07-28 17:33:20]

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/script_ref.dart (right):

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/script_ref.dart:14: class ScriptRefElement
extends HtmlElement implements Renderable{
On 2016/07/28 17:15:55, turnidge wrote:
> Add a space in "Renderable{"

Done.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/script_ref.dart:59: ..text =
script.uri.split('/').last
On 2016/07/28 17:15:55, turnidge wrote:
> Could this be script.uri.pathSegments.last to avoid the call to split?

That is not an actual Uri, it is a String.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/source_link.dart (right):

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:1: // Copyright (c) 2013,
the Dart project authors.  Please see the AUTHORS file
On 2016/07/28 17:15:55, turnidge wrote:
> Update date here and in all other files you are adding: 2016.

Done.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:15: class
SourceLinkElement extends HtmlElement implements Renderable{
On 2016/07/28 17:15:55, turnidge wrote:
> Add space between Renderable and {.

Done.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:21: 
On 2016/07/28 17:15:56, turnidge wrote:
> Remove extra blank line.

Done.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:57: void detached() {
super.detached(); children = []; _r.disable(notify: true); }
On 2016/07/28 17:15:56, turnidge wrote:
> Can this detached/RenderingScheduler/onRendered boilerplate be shared somehow?

> Maybe a mixin?  How about the attached?  Is there a way to share some of this
> code across elements?

It is possible to move the properties to a mixin.
I'm not sure about the attached, it needs to call super.attached() that comes
from HtmlElement.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link.dart:63: String label =
_script.uri.split('/').last;
On 2016/07/28 17:15:56, turnidge wrote:
> pathSegments

That is not an actual Uri, it is a String.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/source_link_wrapper.dart (right):

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/source_link_wrapper.dart:1: // Copyright
(c) 2013, the Dart project authors.  Please see the AUTHORS file
On 2016/07/28 17:15:56, turnidge wrote:
> 2016, you get the idea.

Done.

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/mocks/objects/script.dart (right):

https://codereview.chromium.org/2180553002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/mocks/objects/script.dart:27: 
On 2016/07/28 17:15:56, turnidge wrote:
> Remove extra blank line here.

Done.

[Cutch, 2016-07-29 14:22:20]

lgtm

[cbernaschina, 2016-08-01 23:29:57]

Description was changed from

==========
Converted Observatory source-link & script-ref elements
==========

to

==========
Converted Observatory source-link & script-ref elements

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/445180ad4179029f32f32d2f0645a40b7ec3cebd
==========

[cbernaschina, 2016-08-01 23:29:58]

Committed patchset #9 (id:160001) manually as
445180ad4179029f32f32d2f0645a40b7ec3cebd (presubmit successful).