chrome/browser/installable/installable_manager_browsertest.cc - Issue 2178833002: Add new app banner metrics using InstallableStatusCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/installable/installable_manager_browsertest.cc

Issue 2178833002: Add new app banner metrics using InstallableStatusCode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-integrate-checker-no-refptr

Patch Set: Fix histogram name Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/installable/installable_manager.cc ('k') | chrome/browser/installable/installable_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/installable/installable_manager_browsertest.cc

diff --git a/chrome/browser/installable/installable_manager_browsertest.cc b/chrome/browser/installable/installable_manager_browsertest.cc

index ea63eabb4e5cb2390257ee6adf61c35f97c8b247..78c578319a30e4db50966b3f38e6118fa1234b6b 100644

--- a/chrome/browser/installable/installable_manager_browsertest.cc

+++ b/chrome/browser/installable/installable_manager_browsertest.cc

@@ -58,7 +58,7 @@ class CallbackTester {

base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, quit_closure_);

}

- InstallableErrorCode error_code() const { return error_code_; }

+ InstallableStatusCode error_code() const { return error_code_; }

const GURL& manifest_url() const { return manifest_url_; }

const content::Manifest& manifest() const { return manifest_; }

const GURL& icon_url() const { return icon_url_; }

@@ -67,7 +67,7 @@ class CallbackTester {

private:

base::Closure quit_closure_;

- InstallableErrorCode error_code_;

+ InstallableStatusCode error_code_;

GURL manifest_url_;

content::Manifest manifest_;

GURL icon_url_;

@@ -121,7 +121,7 @@ class NestedCallbackTester {

InstallableManager* manager_;

InstallableParams params_;