Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_observer.cc

Issue 217883004: [Signin] Factor out a helper class to load a continue URL once Sync is configured. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update a #include location Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_observer.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_observer.cc b/chrome/browser/ui/sync/one_click_signin_sync_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..376baeb05053159db327700d975c1448a3128a7b
--- /dev/null
+++ b/chrome/browser/ui/sync/one_click_signin_sync_observer.cc
@@ -0,0 +1,119 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/sync/one_click_signin_sync_observer.h"
+
+#include "base/bind.h"
+#include "base/message_loop/message_loop.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/signin/signin_promo.h"
+#include "chrome/browser/sync/profile_sync_service.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_delegate.h"
+
+namespace {
+
+void CloseTab(content::WebContents* tab) {
+ content::WebContentsDelegate* tab_delegate = tab->GetDelegate();
+ if (tab_delegate)
+ tab_delegate->CloseContents(tab);
+}
+
+} // namespace
+
+
+OneClickSigninSyncObserver::OneClickSigninSyncObserver(
+ content::WebContents* web_contents,
+ const GURL& continue_url)
+ : content::WebContentsObserver(web_contents),
+ continue_url_(continue_url),
+ weak_ptr_factory_(this) {
+ DCHECK(!continue_url_.is_empty());
+
+ ProfileSyncService* sync_service = GetSyncService(web_contents);
+ if (sync_service) {
+ sync_service->AddObserver(this);
+ } else {
+ LoadContinueUrl();
+ // Post a task rather than calling |delete this| here, so that the
+ // destructor is not called directly from the constructor. Note that it's
+ // important to pass a weak pointer rather than base::Unretained(this)
+ // because it's possible for e.g. WebContentsDestroyed() to be called
+ // before this task has a chance to run.
+ base::MessageLoop::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&OneClickSigninSyncObserver::DeleteObserver,
+ weak_ptr_factory_.GetWeakPtr()));
+ }
+}
+
+OneClickSigninSyncObserver::~OneClickSigninSyncObserver() {}
+
+void OneClickSigninSyncObserver::WebContentsDestroyed(
+ content::WebContents* web_contents) {
+ ProfileSyncService* sync_service = GetSyncService(web_contents);
+ if (sync_service)
+ sync_service->RemoveObserver(this);
+
+ delete this;
+}
+
+void OneClickSigninSyncObserver::OnStateChanged() {
+ ProfileSyncService* sync_service = GetSyncService(web_contents());
+
+ // At this point, the sign-in process is complete, and control has been handed
+ // back to the sync engine. Close the gaia sign in tab if the |continue_url_|
+ // contains the |auto_close| parameter. Otherwise, wait for sync setup to
+ // complete and then navigate to the |continue_url_|.
+ if (signin::IsAutoCloseEnabledInURL(continue_url_)) {
+ // Close the Gaia sign-in tab via a task to make sure we aren't in the
+ // middle of any WebUI handler code.
+ base::MessageLoop::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&CloseTab, base::Unretained(web_contents())));
+ } else {
+ if (sync_service->FirstSetupInProgress()) {
+ // Sync setup has not completed yet. Wait for it to complete.
+ return;
+ }
+
+ if (sync_service->sync_initialized() &&
+ signin::GetSourceForPromoURL(continue_url_)
+ != signin::SOURCE_SETTINGS) {
+ // TODO(isherman): Redirecting after Sync is set up still has some bugs:
+ // http://crbug.com/355885
+ // Having multiple settings pages open can cause issues.
+ // http://crbug.com/357901
+ // Selecting anything other than "Sync Everything" when configuring Sync
+ // prevents the redirect.
+ LoadContinueUrl();
+ }
+ }
+
+ sync_service->RemoveObserver(this);
+ delete this;
+}
+
+void OneClickSigninSyncObserver::LoadContinueUrl() {
+ web_contents()->GetController().LoadURL(
+ continue_url_,
+ content::Referrer(),
+ content::PAGE_TRANSITION_AUTO_TOPLEVEL,
+ std::string());
+}
+
+ProfileSyncService* OneClickSigninSyncObserver::GetSyncService(
+ content::WebContents* web_contents) {
+ Profile* profile =
+ Profile::FromBrowserContext(web_contents->GetBrowserContext());
+ return ProfileSyncServiceFactory::GetForProfile(profile);
+}
+
+// static
+void OneClickSigninSyncObserver::DeleteObserver(
+ base::WeakPtr<OneClickSigninSyncObserver> observer) {
+ if (observer)
+ delete observer.get();
+}

Powered by Google App Engine
This is Rietveld 408576698