Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2178073005: Refactoring: Remove calling prune() in clear() in ImageResource (Closed)

Created:
4 years, 4 months ago by hajimehoshi
Modified:
4 years, 4 months ago
Reviewers:
hiroshige, Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Remove calling prune() in clear() in ImageResource This CL removes calling prune() in clear() since the image is cleared immediately and there is no use in pruning here. BUG=n/a TEST=webkit_unit_tests --gtest_filter=ImageResourceTest.* Committed: https://crrev.com/27ad5b198a71390175560f35b32d221331f53af5 Cr-Commit-Position: refs/heads/master@{#408095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
hajimehoshi
PTAL
4 years, 4 months ago (2016-07-26 06:26:05 UTC) #2
hiroshige
lgtm.
4 years, 4 months ago (2016-07-26 06:50:06 UTC) #3
Mike West
LGTM, thanks!
4 years, 4 months ago (2016-07-27 08:43:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178073005/1
4 years, 4 months ago (2016-07-27 09:20:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 11:28:53 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 11:30:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27ad5b198a71390175560f35b32d221331f53af5
Cr-Commit-Position: refs/heads/master@{#408095}

Powered by Google App Engine
This is Rietveld 408576698