Fix IME on bookmark edit dialog.

Fix IME on bookmark edit dialog.

On bookmark edit dialog, text fields gets logical focus
first, then NativeTextFieldViews gets real win32 focus,
in which case InputMethodTSF fails to set focused
TextInputClient for TSF.

This CL adds calling InputMethod()->OnFocus() when
NativeTextFieldViews (which is a TextInputClient as well)
gets focus, to make sure InputMethodTSF can properly
pass focused TextInputClient to TSF.

BUG=265337
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216992

[kochi, 2013-08-09 10:19:52]

Hi Mike,

This is my fix for the bookmark dialog issue.
I made sure this works on Windows7 with TSF enabled.

Could you review this?

Yukawa-san, Nona-san,
Could you also take a look at this change?

If possible, I would like to commit this before M30 branch.

[Yohei Yukawa, 2013-08-09 11:37:14]

lgtm

[msw, 2013-08-09 18:01:09]

LGTM with a Q.

https://codereview.chromium.org/21751002/diff/4001/ui/views/controls/textfiel...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/21751002/diff/4001/ui/views/controls/textfiel...
ui/views/controls/textfield/native_textfield_views.cc:693: void
NativeTextfieldViews::HandleBlur() {
Should HandleBlur call GetInputMethod()->OnBlur(), or is that done elsewhere?

[kochi, 2013-08-10 01:25:54]

Thanks for the review!

On 2013/08/09 18:01:09, msw wrote:
> LGTM with a Q.
> 
>
https://codereview.chromium.org/21751002/diff/4001/ui/views/controls/textfiel...
> File ui/views/controls/textfield/native_textfield_views.cc (right):
> 
>
https://codereview.chromium.org/21751002/diff/4001/ui/views/controls/textfiel...
> ui/views/controls/textfield/native_textfield_views.cc:693: void
> NativeTextfieldViews::HandleBlur() {
> Should HandleBlur call GetInputMethod()->OnBlur(), or is that done elsewhere?

As TextInputClient's focus handling is basically all done in OnFocus()
(which replaces old focus with new), it's okay but for symmetry I think it
should be
safe to call OnBlur from HandleBlur().

Also, linux_chromeos keyboard_unittest failure looks real, I'll look into it.

[kochi, 2013-08-12 04:50:13]

Looks like linux_chromeos:keyboard_unittests failure is not me.
Added calling OnBlur() call from HandleBlur().
Manual tested locally and looks it is working well.

https://codereview.chromium.org/21751002/diff/4001/ui/views/controls/textfiel...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/21751002/diff/4001/ui/views/controls/textfiel...
ui/views/controls/textfield/native_textfield_views.cc:693: void
NativeTextfieldViews::HandleBlur() {
On 2013/08/09 18:01:09, msw wrote:
> Should HandleBlur call GetInputMethod()->OnBlur(), or is that done elsewhere?

Done.

[kochi, 2013-08-12 08:17:15]

Given the LGTMs and trybots results from new change,
I'm submitting this via CQ.

[commit-bot: I haz the power, 2013-08-12 08:17:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/21751002/21001

[commit-bot: I haz the power, 2013-08-12 14:48:36]

Change committed as 216992