Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 21743003: Rearrange net.gyp to enable adding flip server unittests to net_unittests. (Closed)

Created:
7 years, 4 months ago by yhirano
Modified:
7 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rearrange net.gyp to enable adding flip server unittests to net_unittests. flip_in_mem_edsm_server should have unittests. BUG=267354 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215802

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M net/net.gyp View 1 2 3 4 4 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yhirano
7 years, 4 months ago (2013-08-02 07:32:35 UTC) #1
Ryan Hamilton
https://codereview.chromium.org/21743003/diff/1/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/21743003/diff/1/net/net.gyp#newcode2673 net/net.gyp:2673: 'target_name': 'flip_in_mem_edsm_server_unittests', Instead of a new target, how 'bout ...
7 years, 4 months ago (2013-08-02 23:30:48 UTC) #2
yhirano
https://codereview.chromium.org/21743003/diff/1/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/21743003/diff/1/net/net.gyp#newcode2673 net/net.gyp:2673: 'target_name': 'flip_in_mem_edsm_server_unittests', On 2013/08/02 23:30:48, Ryan Hamilton wrote: > ...
7 years, 4 months ago (2013-08-05 02:05:23 UTC) #3
Ryan Hamilton
Looking better! What happened to tools/flip_server/test/run_all_unittests.cc? https://codereview.chromium.org/21743003/diff/14001/net/net.gyp File net/net.gyp (left): https://codereview.chromium.org/21743003/diff/14001/net/net.gyp#oldcode2616 net/net.gyp:2616: 'flip_balsa_and_epoll_library', It's not ...
7 years, 4 months ago (2013-08-05 15:27:19 UTC) #4
yhirano
On 2013/08/05 15:27:19, Ryan Hamilton wrote: > What happened to tools/flip_server/test/run_all_unittests.cc? I thought that it ...
7 years, 4 months ago (2013-08-05 15:49:16 UTC) #5
Ryan Hamilton
On 2013/08/05 15:49:16, yhirano wrote: > On 2013/08/05 15:27:19, Ryan Hamilton wrote: > > What ...
7 years, 4 months ago (2013-08-05 16:38:09 UTC) #6
yhirano
https://codereview.chromium.org/21743003/diff/14001/net/net.gyp File net/net.gyp (left): https://codereview.chromium.org/21743003/diff/14001/net/net.gyp#oldcode2616 net/net.gyp:2616: 'flip_balsa_and_epoll_library', On 2013/08/05 15:27:19, Ryan Hamilton wrote: > It's ...
7 years, 4 months ago (2013-08-06 02:00:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/21743003/26001
7 years, 4 months ago (2013-08-06 02:03:22 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 05:44:51 UTC) #9
Message was sent while issue was closed.
Change committed as 215802

Powered by Google App Engine
This is Rietveld 408576698