[Payments] Use the correct index when checking addresses

[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have multiple children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the "merchant doesn't accept address" string is
correctly displayed.

* Plumbs a new callback that indicates that the client has finished
checking the selection.

BUG=630348
Committed: https://crrev.com/80155b30015fca0ea8774117ee2a9b8d0d8da91d
Cr-Commit-Position: refs/heads/master@{#407197}

[gone, 2016-07-21 18:07:46]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 18:08:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:29:20]

Dry run: This issue passed the CQ dry run.

[gone, 2016-07-22 03:17:17]

Description was changed from

==========
[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have
multiple children in it above the actual options.

BUG=630348
==========

to

==========
[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have multiple
children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the
"merchant doesn't accept address" string is
correctly displayed.

BUG=630348
==========

[gone, 2016-07-22 03:17:57]

Description was changed from

==========
[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have multiple
children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the
"merchant doesn't accept address" string is
correctly displayed.

BUG=630348
==========

to

==========
[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have multiple
children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the
"merchant doesn't accept address" string is
correctly displayed.

* Plumbs a new callback that indicates that the client has finished
checking the selection.

BUG=630348
==========

[gone, 2016-07-22 03:19:41]

dfalcantara@chromium.org changed reviewers:
+ rouslan@chromium.org

[gone, 2016-07-22 03:19:41]

Rouslan: PTAL.  Got the new test working.  It double-dips: it checks that the
"pick a different address" string pops up and and that it doesn't crash at the
same time.

[gone, 2016-07-22 03:19:59]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 03:20:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:50:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 03:50:46]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-07-22 04:22:09]

lgtm % comment

https://codereview.chromium.org/2170603006/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
(right):

https://codereview.chromium.org/2170603006/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java:101:
* Make sure the address suggestions are in the correct order and that only the
top 4
Please update the comment.

[gone, 2016-07-22 17:17:56]

https://chromiumcodereview.appspot.com/2170603006/diff/20001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
(right):

https://chromiumcodereview.appspot.com/2170603006/diff/20001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java:101:
* Make sure the address suggestions are in the correct order and that only the
top 4
On 2016/07/22 04:22:09, rouslan wrote:
> Please update the comment.

Ugh.  I'm swear that I'm usually less absent-minded than this.  What was I
talking about?

[gone, 2016-07-22 17:18:01]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-07-22 17:18:01]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2170603006/#ps40001
(title: "Comment")

[commit-bot: I haz the power, 2016-07-22 17:18:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 17:56:51]

Description was changed from

==========
[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have multiple
children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the
"merchant doesn't accept address" string is
correctly displayed.

* Plumbs a new callback that indicates that the client has finished
checking the selection.

BUG=630348
==========

to

==========
[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have multiple
children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the
"merchant doesn't accept address" string is
correctly displayed.

* Plumbs a new callback that indicates that the client has finished
checking the selection.

BUG=630348
==========

[commit-bot: I haz the power, 2016-07-22 17:56:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 17:58:26]

Description was changed from

==========
[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have multiple
children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the
"merchant doesn't accept address" string is
correctly displayed.

* Plumbs a new callback that indicates that the client has finished
checking the selection.

BUG=630348
==========

to

==========
[Payments] Use the correct index when checking addresses

We have an off-by-one error now that the mOptionLayout can have multiple
children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the
"merchant doesn't accept address" string is
correctly displayed.

* Plumbs a new callback that indicates that the client has finished
checking the selection.

BUG=630348

Committed: https://crrev.com/80155b30015fca0ea8774117ee2a9b8d0d8da91d
Cr-Commit-Position: refs/heads/master@{#407197}
==========

[commit-bot: I haz the power, 2016-07-22 17:58:27]

Patchset 3 (id:??) landed as
https://crrev.com/80155b30015fca0ea8774117ee2a9b8d0d8da91d
Cr-Commit-Position: refs/heads/master@{#407197}