Spell check whole content of an editable element when it gets focused.

Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 78 matching lines @@
 using namespace Unicode;
 
 namespace {
 
 bool isSelectionInTextField(const VisibleSelection& selection)
 {
     HTMLTextFormControlElement* textControl = enclosingTextFormControl(selection.start());
     return textControl && textControl->hasTagName(inputTag) && toHTMLInputElement(textControl)->isTextField();
 }
 
+// Spell checks whole contents of a editable element (<input="text"/>, <textarea> or contenteditable)
+// This gets called when any editable element gets focused.
+void elementDidBeginEditing(Element* element)
+{
+    if (Frame* frame = element->document()->frame()) {
+        if (frame->editor()->isContinuousSpellCheckingEnabled()) {
+            VisibleSelection selection = VisibleSelection::selectionFromContentsOfNode(element);
+            frame->editor()->markMisspellingsAndBadGrammar(selection);

[tony, 2013/08/02 17:01:17]

Is it really OK to check all of a contentEditable or textarea?  If you have lots
of text (e.g., many megabytes), won't this cause the UI to hang?

+        }
+    }
+}
+
 } // namespace
 
 // When an event handler has moved the selection outside of a text control
 // we should use the target control's selection for this editing operation.
 VisibleSelection Editor::selectionForCommand(Event* event)
 {
     VisibleSelection selection = m_frame->selection()->selection();
     if (!event)
         return selection;
     // If the target is a text control, and the current selection is outside of its shadow tree,
@@ skipping 945 matching lines @@
 {
     return client() && client()->canRedo();
 }
 
 void Editor::redo()
 {
     if (client())
         client()->redo();
 }
 
-void Editor::didBeginEditing()
+void Editor::didBeginEditing(Element* rootEditableElement)
 {
+    elementDidBeginEditing(rootEditableElement);
+
     if (client())
         client()->didBeginEditing();
 }
 
-void Editor::didEndEditing()
+void Editor::didEndEditing(Element*)
 {
     if (client())
         client()->didEndEditing();
 }
 
 void Editor::setBaseWritingDirection(WritingDirection direction)
 {
     Node* focusedElement = frame()->document()->focusedElement();
     if (focusedElement && isHTMLTextFormControlElement(focusedElement)) {
         if (direction == NaturalWritingDirection)
@@ skipping 998 matching lines @@
 
     // Handle block styles, substracting these from the typing style.
     RefPtr<EditingStyle> blockStyle = typingStyle->extractAndRemoveBlockProperties();
     if (!blockStyle->isEmpty())
         applyCommand(ApplyStyleCommand::create(m_frame->document(), blockStyle.get(), editingAction));
 
     // Set the remaining style as the typing style.
     m_frame->selection()->setTypingStyle(typingStyle);
 }
 
+void Editor::textAreaDidBeginEditing(Element* e)
+{
+    elementDidBeginEditing(toHTMLTextFormControlElement(e)->innerTextElement());
+}
 
 void Editor::textFieldDidBeginEditing(Element* e)
 {
-    if (isContinuousSpellCheckingEnabled()) {
-        Element* element = toHTMLTextFormControlElement(e)->innerTextElement();
-        VisibleSelection selection = VisibleSelection::selectionFromContentsOfNode(element);
-        markMisspellingsAndBadGrammar(selection);
-    }
+    elementDidBeginEditing(toHTMLTextFormControlElement(e)->innerTextElement());

[tony, 2013/08/02 17:01:17]

textFieldDidBeginEditing and textAreaDidBeginEditing seem the same. Why not have
a single function?  It could be called textAreaOrTextFieldDidBeginEditing.

 }
 
 void Editor::textFieldDidEndEditing(Element* e)
 {
     // Remove markers when deactivating a selection in an <input type="text"/>.
     // Prevent new ones from appearing too.
     m_spellChecker->cancelCheck();
     HTMLTextFormControlElement* textFormControlElement = toHTMLTextFormControlElement(e);
     HTMLElement* innerText = textFormControlElement->innerTextElement();
     DocumentMarker::MarkerTypes markerTypes(DocumentMarker::Spelling);
@@ skipping 271 matching lines @@
     return WebCore::unifiedTextCheckerEnabled(m_frame);
 }
 
 void Editor::toggleOverwriteModeEnabled()
 {
     m_overwriteModeEnabled = !m_overwriteModeEnabled;
     frame()->selection()->setShouldShowBlockCursor(m_overwriteModeEnabled);
 };
 
 } // namespace WebCore