Rename AutofillDialogController to AutofillDialogViewDelegate.

Rename AutofillDialogController to AutofillDialogViewDelegate.

BUG=259089
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215951

[aruslan, 2013-08-02 01:36:02]

PTAL.
This patch assumes that the old dialog implementation on Android is already
ripped off (cf https://chromiumcodereview.appspot.com/21205007/)

[Evan Stade, 2013-08-02 04:46:20]

lgtm

[aruslan, 2013-08-02 19:55:41]

Rachel -- PTAL and apply the Cocoa seal of approval if appropriate, thanks!

[groby-ooo-7-16, 2013-08-02 20:22:21]

1) While the Cocoa stuff looks OK technically, I can't really approve - I'm not
OWNER :( Added isherman, who actually has approval powers.

2) There's technically a lot more renaming to be done - I've stopped annotating
after a while :)

3) This is an unfortunate rename. Usually, delegates are incidental to object
use, while controllers are mandatory.

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.h (right):

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.h:69: class
AutofillDialogControllerImpl : public AutofillDialogViewDelegate,
This should then be an AutofillDialogViewDelegateImpl, no?

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm
(right):

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm:31:
testing::NiceMock<autofill::MockAutofillDialogViewDelegate> controller_;
should be delegate_

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm
(right):

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm:27:
testing::NiceMock<autofill::MockAutofillDialogViewDelegate> controller_;
delegate_

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h (right):

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h:81:
AutofillDialogViewDelegate* controller() { return controller_; }
delegate - here and elsewhere

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/cocoa/a...
File chrome/browser/ui/cocoa/autofill/autofill_main_container.mm (right):

https://codereview.chromium.org/21692002/diff/11001/chrome/browser/ui/cocoa/a...
chrome/browser/ui/cocoa/autofill/autofill_main_container.mm:36: -
(id)initWithController:(autofill::AutofillDialogViewDelegate*)controller {
initWithDelegate...

[groby-ooo-7-16, 2013-08-02 20:23:41]

To be clear: If we _must_ choose this name, I'm not going to stand on principle.
I just find it a confusing choice. So, provided there'll be more CL's with the
missing renames, a technical LGTM. (You'll still need Ilya)

[aruslan, 2013-08-02 20:35:50]

On 2013/08/02 20:23:41, groby wrote:
> To be clear: If we _must_ choose this name, I'm not going to stand on
principle.
> I just find it a confusing choice. So, provided there'll be more CL's with the
> missing renames, a technical LGTM. (You'll still need Ilya)

Thanks, Rachel!
I'll rename the rest of controller_ occurrences once we are clear on the names.

Ilya -- PTAL, thanks! :)

[Ilya Sherman, 2013-08-02 20:57:30]

LGTM stamp of approval

[Evan Stade, 2013-08-02 22:18:47]

On 2013/08/02 20:57:30, Ilya Sherman wrote:
> LGTM stamp of approval

[Evan Stade, 2013-08-02 22:19:58]

oops, pressed send too early...

I agree with Rachel that controller() and controller_ names should become
delegate() and delegate_. Had an offline chat with Rachel and we can't think of
a better naming scheme to distinguish the new and old interfaces.

[aruslan, 2013-08-02 22:21:27]

On 2013/08/02 22:19:58, Evan Stade wrote:
> oops, pressed send too early...
> 
> I agree with Rachel that controller() and controller_ names should become
> delegate() and delegate_. Had an offline chat with Rachel and we can't think
of
> a better naming scheme to distinguish the new and old interfaces.

No worries, it's incoming.
The code started looking a bit too over-delegated and under-controlled, though.

[commit-bot: I haz the power, 2013-08-06 16:17:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aruslan@chromium.org/21692002/72001

[commit-bot: I haz the power, 2013-08-06 19:39:20]

Change committed as 215951