Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 21690005: Only submit HomePageIsNewTabPage metric when ShowHomeButton is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/Home/home/ Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_metrics_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d7d32e6038d7d49f73b19e747b27c9f1b9dde0ec..e69f2a55265cfa9163f685dc5f23fcb8a9e99cae 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -13094,7 +13094,19 @@ other types of suffix sets.
</summary>
</histogram>
+<histogram name="Settings.GivenShowHomeButton_HomePageIsNewTabPage"
+ enum="Boolean">
+ <summary>
+ Whether or not the home page user preference is set to the default NTP value
+ when a profile is loaded. This is only logged if the home button is shown.
+ </summary>
+</histogram>
+
<histogram name="Settings.HomePageIsNewTabPage" enum="Boolean">
+ <obsolete>
+ Deprecated 08/05/2013. Replaced by
+ Settings.GivenShowHomeButton_HomePageIsNewTabPage.
+ </obsolete>
<summary>
Whether or not the home page user preference is set to the default NTP value
when a profile is loaded.
@@ -13103,7 +13115,7 @@ other types of suffix sets.
<histogram name="Settings.ShowHomeButton" enum="BooleanEnabled">
<summary>
- Whether or not the Home button is enabled in user preferences when a profile
+ Whether or not the home button is enabled in user preferences when a profile
is loaded.
</summary>
</histogram>
« no previous file with comments | « chrome/browser/prefs/pref_metrics_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698