Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: tools/telemetry/telemetry/core/browser_unittest.py

Issue 21682002: Expose GPU information to Telemetry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refactored more code into WebSocketBrowserConnection on nduca's request. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/browser_unittest.py
diff --git a/tools/telemetry/telemetry/core/browser_unittest.py b/tools/telemetry/telemetry/core/browser_unittest.py
index 81a80f71b70192df343d6aaa23797868bcd1fb44..2493b9cccad9a3d0019b3efe6564804fb0ed181f 100644
--- a/tools/telemetry/telemetry/core/browser_unittest.py
+++ b/tools/telemetry/telemetry/core/browser_unittest.py
@@ -6,6 +6,9 @@ import os
import unittest
from telemetry.core import browser_finder
+from telemetry.core import gpu_device
+from telemetry.core import gpu_info
+from telemetry.core import system_info
from telemetry.unittest import options_for_unittests
class BrowserTest(unittest.TestCase):
@@ -123,3 +126,22 @@ class BrowserTest(unittest.TestCase):
return
self.assertEquals(1, len(b.tabs))
+
+ def testGetSystemInfo(self):
+ b = self.CreateBrowser()
+ if not b.supports_system_info:
+ logging.warning(
+ 'Browser does not support getting system info, skipping test.')
+ return
+
+ info = b.GetSystemInfo()
+
+ self.assertTrue(isinstance(info, system_info.SystemInfo))
+ self.assertTrue(hasattr(info, 'model_name'))
+ self.assertTrue(hasattr(info, 'gpu'))
+ self.assertTrue(isinstance(info.gpu, gpu_info.GPUInfo))
+ self.assertTrue(hasattr(info.gpu, 'devices'))
+ self.assertTrue(len(info.gpu.devices) > 0)
+ for g in info.gpu.devices:
+ self.assertTrue(isinstance(g, gpu_device.GPUDevice))
+

Powered by Google App Engine
This is Rietveld 408576698