Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 21680002: Up the window.localstorage limit to 10M from 5M. (Closed)

Created:
5 years, 3 months ago by michaeln
Modified:
5 years, 3 months ago
Reviewers:
ericu, Eric U.
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Up the window.localstorage limit to 10M from 5M. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215402

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webkit/common/dom_storage/dom_storage_types.h View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaeln
like we've talked about, just bump the number a little
5 years, 3 months ago (2013-08-02 01:05:39 UTC) #1
ericu
lgtm https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom_storage_types.h File webkit/common/dom_storage/dom_storage_types.h (right): https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom_storage_types.h#newcode20 webkit/common/dom_storage/dom_storage_types.h:20: // This value is enforced in renderer processes. ...
5 years, 3 months ago (2013-08-02 03:46:22 UTC) #2
michaeln
https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom_storage_types.h File webkit/common/dom_storage/dom_storage_types.h (right): https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom_storage_types.h#newcode20 webkit/common/dom_storage/dom_storage_types.h:20: // This value is enforced in renderer processes. On ...
5 years, 3 months ago (2013-08-02 19:15:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/21680002/11001
5 years, 3 months ago (2013-08-02 19:16:09 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=155646
5 years, 3 months ago (2013-08-02 20:19:05 UTC) #5
michaeln
cq doesn't work well in practice, which is why i never used it with gcl/svn ...
5 years, 3 months ago (2013-08-02 20:23:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/21680002/11001
5 years, 3 months ago (2013-08-02 20:33:03 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2013-08-02 23:20:51 UTC) #8
Message was sent while issue was closed.
Change committed as 215402

Powered by Google App Engine
This is Rietveld 408576698