Instrumenting missing API calls

Instrumenting missing API calls.
Adding a framework to detect cases when a developer forgets to instrument API calls. Since all our code should execute in instrumented callbacks, 'tasks' check that we are in an instrumented callback at qualifying entrypoints.

Adding missing instrumentations.

BUG=164227
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215444

[rgustafson, 2013-08-02 18:43:38]

https://codereview.chromium.org/21661003/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/utility.js (right):

https://codereview.chromium.org/21661003/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/utility.js:93: function
checkInstrumentedCallback() {
checkInInstrumentedCallback

https://codereview.chromium.org/21661003/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/utility.js:100: alert(error);
This alert is included in the file wide "remove alerts", right? Can we add a
time to when we will remove these? beta?

The functionality you're trying to achieve seems more like a unit test.

https://codereview.chromium.org/21661003/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/utility.js:262: 'Instrumented callback in
not instrumented upon exit');
in -> is

[vadimt, 2013-08-02 19:19:25]

https://codereview.chromium.org/21661003/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/utility.js (right):

https://codereview.chromium.org/21661003/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/utility.js:93: function
checkInstrumentedCallback() {
On 2013/08/02 18:43:38, rgustafson wrote:
> checkInInstrumentedCallback

Done.

https://codereview.chromium.org/21661003/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/utility.js:262: 'Instrumented callback in
not instrumented upon exit');
On 2013/08/02 18:43:38, rgustafson wrote:
> in -> is

Done.

[rgustafson, 2013-08-02 22:14:26]

lgtm

[vadimt, 2013-08-02 22:21:55]

arv@, please provide OWNER's approval

[arv (Not doing code reviews), 2013-08-02 22:41:52]

LGTM

https://codereview.chromium.org/21661003/diff/6001/chrome/browser/resources/g...
File chrome/browser/resources/google_now/utility.js (right):

https://codereview.chromium.org/21661003/diff/6001/chrome/browser/resources/g...
chrome/browser/resources/google_now/utility.js:100: alert(error);
why both alert and console.log?

[vadimt, 2013-08-02 22:47:04]

https://codereview.chromium.org/21661003/diff/6001/chrome/browser/resources/g...
File chrome/browser/resources/google_now/utility.js (right):

https://codereview.chromium.org/21661003/diff/6001/chrome/browser/resources/g...
chrome/browser/resources/google_now/utility.js:100: alert(error);
On 2013/08/02 22:41:52, arv wrote:
> why both alert and console.log?

Alert to know that this has happened at all.
console.error - to easily attach console output to bug reports.
Also, I see that alert dialogs from time to time have glitches that make
information unreadable.

[commit-bot: I haz the power, 2013-08-02 22:48:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/21661003/6001

[commit-bot: I haz the power, 2013-08-03 01:39:14]

Change committed as 215444