Fix tests in when MD is set to EXPERIMENTAL by default

chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"
 
 #include "ash/common/ash_switches.h"
+#include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/shelf/shelf_types.h"
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
@@ skipping 101 matching lines @@
 
   // By default, the tabstrip and toolbar should be visible.
   EXPECT_TRUE(tabstrip->visible());
   EXPECT_TRUE(toolbar->visible());
 
   ToggleFullscreen();
   EXPECT_TRUE(browser_view()->GetWidget()->IsFullscreen());
   EXPECT_TRUE(controller()->IsEnabled());
   EXPECT_FALSE(controller()->IsRevealed());
 
-  // Entering immersive fullscreen should make the tab strip use the immersive
-  // style and hide the toolbar.
-  EXPECT_TRUE(tabstrip->visible());
-  EXPECT_TRUE(tabstrip->IsImmersiveStyle());
-  EXPECT_FALSE(toolbar->visible());
+  // In MD, tab strip and tool bar are both hidden in immersive fullscreen mode;

[tdanderson, 2016/07/19 21:10:24]

Suggested rewording of entire comment: "For MD, the browser's top chrome is
completely hidden in immersive fullscreen mode."

[yiyix, 2016/07/20 06:03:08]

Done.

+  // whereas the tab strip are are shown in non-MD.
+  if (ash::MaterialDesignController::IsShelfMaterial()) {
+    EXPECT_FALSE(tabstrip->visible());
+    EXPECT_FALSE(toolbar->visible());
+  } else {
+    EXPECT_TRUE(tabstrip->visible());
+    EXPECT_TRUE(tabstrip->IsImmersiveStyle());

[tdanderson, 2016/07/19 21:10:24]

I'd move this to line 131 assuming it is true in both non-MD and MD.

[yiyix, 2016/07/20 06:03:08]

Done.

+    EXPECT_FALSE(toolbar->visible());
+  }
 
   // The tab indicators should be flush with the top of the widget.
   EXPECT_EQ(0, GetBoundsInWidget(tabstrip).y());
 
-  // The web contents should be immediately below the tab indicators.
-  EXPECT_EQ(Tab::GetImmersiveHeight(),
-            GetBoundsInWidget(contents_web_view).y());
+  // In MD, since tab strip and tool bar are both hidden in immersive fullscreen
+  // mode, the web connents should extend to the edge of screen. In non-MD, the

[tdanderson, 2016/07/19 21:10:24]

connents->contents

[yiyix, 2016/07/20 06:03:08]

I was careless. Thanks.

+  // web contents should be immediately below the tab indicators.
+  if (ash::MaterialDesignController::IsShelfMaterial()) {

[tdanderson, 2016/07/19 21:10:23]

nit: consider using a local variable const bool md_shelf =
...::IsShelfMaterial() to avoid the need to call this multiple times

[yiyix, 2016/07/20 06:03:08]

Done.

+    EXPECT_EQ(0, GetBoundsInWidget(contents_web_view).y());
+  } else {
+    EXPECT_EQ(Tab::GetImmersiveHeight(),
+              GetBoundsInWidget(contents_web_view).y());
+  }
 
   // Revealing the top-of-window views should set the tab strip back to the
   // normal style and show the toolbar.
   AttemptReveal();
   EXPECT_TRUE(controller()->IsRevealed());
   EXPECT_TRUE(tabstrip->visible());
   EXPECT_FALSE(tabstrip->IsImmersiveStyle());
   EXPECT_TRUE(toolbar->visible());
 
   // The TopContainerView should be flush with the top edge of the widget. If
   // it is not flush with the top edge the immersive reveal animation looks
   // wonky.
   EXPECT_EQ(0, GetBoundsInWidget(browser_view()->top_container()).y());
 
   // The web contents should be at the same y position as they were when the
   // top-of-window views were hidden.
-  EXPECT_EQ(Tab::GetImmersiveHeight(),
-            GetBoundsInWidget(contents_web_view).y());
+  if (ash::MaterialDesignController::IsShelfMaterial()) {
+    EXPECT_EQ(0, GetBoundsInWidget(contents_web_view).y());
+  } else {
+    EXPECT_EQ(Tab::GetImmersiveHeight(),
+              GetBoundsInWidget(contents_web_view).y());
+  }
 
   // Repeat the test for when in both immersive fullscreen and tab fullscreen.
   SetTabFullscreen(true);
   // Hide and reveal the top-of-window views so that they get relain out.
   AttemptUnreveal();
   AttemptReveal();
 
   // The tab strip and toolbar should still be visible and the TopContainerView
   // should still be flush with the top edge of the widget.
   EXPECT_TRUE(controller()->IsRevealed());
@@ skipping 60 matching lines @@
 TEST_F(ImmersiveModeControllerAshTest, TabAndBrowserFullscreen) {
   AddTab(browser(), GURL("about:blank"));
 
   // The shelf should start out as visible.
   ash::ShelfLayoutManager* shelf =
       ash::Shell::GetPrimaryRootWindowController()->GetShelfLayoutManager();
   ASSERT_EQ(ash::SHELF_VISIBLE, shelf->visibility_state());
 
   // 1) Test that entering tab fullscreen from immersive fullscreen hides the
   // tab indicators and the shelf.
+  // Note that tab indicators hints are removed from MD, so function
+  // ShouldHideTabIndicators() always return true.

[tdanderson, 2016/07/19 21:10:24]

Omit this comment, and instead replace with expectations, e.g., for line 260:

if (is shelf material)
  EXPECT_TRUE(ShouldHideTabIndicators());
else
  EXPECT_FALSE(ShouldHideTabIndicators());

Similarly for the other three locations.

   ToggleFullscreen();
   ASSERT_TRUE(controller()->IsEnabled());
   EXPECT_EQ(ash::SHELF_AUTO_HIDE, shelf->visibility_state());
-  EXPECT_FALSE(controller()->ShouldHideTabIndicators());
+  if (!ash::MaterialDesignController::IsShelfMaterial())
+    EXPECT_FALSE(controller()->ShouldHideTabIndicators());
 
   SetTabFullscreen(true);
   ASSERT_TRUE(controller()->IsEnabled());
   EXPECT_EQ(ash::SHELF_HIDDEN, shelf->visibility_state());
-  EXPECT_TRUE(controller()->ShouldHideTabIndicators());
+  if (!ash::MaterialDesignController::IsShelfMaterial())
+    EXPECT_TRUE(controller()->ShouldHideTabIndicators());
 
   // 2) Test that exiting tab fullscreen shows the tab indicators and autohides
   // the shelf.
   SetTabFullscreen(false);
   ASSERT_TRUE(controller()->IsEnabled());
   EXPECT_EQ(ash::SHELF_AUTO_HIDE, shelf->visibility_state());
-  EXPECT_FALSE(controller()->ShouldHideTabIndicators());
+  if (!ash::MaterialDesignController::IsShelfMaterial())
+    EXPECT_FALSE(controller()->ShouldHideTabIndicators());
 
   // 3) Test that exiting tab fullscreen and immersive fullscreen
   // simultaneously correctly updates the shelf visibility and whether the tab
   // indicators should be hidden.
   SetTabFullscreen(true);
   ToggleFullscreen();
   ASSERT_FALSE(controller()->IsEnabled());
   EXPECT_EQ(ash::SHELF_VISIBLE, shelf->visibility_state());
-  EXPECT_TRUE(controller()->ShouldHideTabIndicators());
+  if (!ash::MaterialDesignController::IsShelfMaterial())
+    EXPECT_TRUE(controller()->ShouldHideTabIndicators());
 }
 
 // Ensure the circular tab-loading throbbers are not painted as layers in
 // immersive fullscreen, since the tab strip may animate in or out without
 // moving the layers.
 TEST_F(ImmersiveModeControllerAshTest, LayeredSpinners) {
   AddTab(browser(), GURL("about:blank"));
 
   TabStrip* tabstrip = browser_view()->tabstrip();
 
@@ skipping 75 matching lines @@
 
   // Exit immersive fullscreen. The web contents should be back below the window
   // header.
   ToggleFullscreen();
   EXPECT_FALSE(browser_view()->GetWidget()->IsFullscreen());
   EXPECT_FALSE(controller()->IsEnabled());
   EXPECT_FALSE(tabstrip->visible());
   EXPECT_FALSE(toolbar->visible());
   EXPECT_EQ(header_height, GetBoundsInWidget(contents_web_view).y());
 }