Return webcontents and add in test.

Return webcontents needed by sessions API and add in test.

BUG=123266
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215953

[Kristen Dwan, 2013-08-02 18:23:23]

addressed the comments from the previous CL. This should make it a bit easier
for review. Sorry about before.. thanks!

[sky, 2013-08-05 16:16:17]

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/persi...
File chrome/browser/sessions/persistent_tab_restore_service.cc (right):

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/persi...
chrome/browser/sessions/persistent_tab_restore_service.cc:946:
PersistentTabRestoreService::RestoreMostRecentEntry(
nit: don't indent this 4. Either none or 2 (not sure which). The following two
lines should be 4 space indented. Same comment for 958-962.

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/sessi...
File chrome/browser/sessions/session_restore_browsertest.cc (right):

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/sessi...
chrome/browser/sessions/session_restore_browsertest.cc:372: EXPECT_EQ(1U,
content.size());
This should be an assert. As if the size isn't 1, then 373 would crash (assuming
content is empty).

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/sessi...
chrome/browser/sessions/session_restore_browsertest.cc:424: EXPECT_EQ(1U,
content.size());
ASSERT

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/sessi...
chrome/browser/sessions/session_restore_browsertest.cc:424: EXPECT_EQ(1U,
content.size());
ASSERT

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
File chrome/browser/sessions/tab_restore_service_helper.cc (right):

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
chrome/browser/sessions/tab_restore_service_helper.cc:174:
TabRestoreServiceHelper::RestoreMostRecentEntry(
Same indentation comment.

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
chrome/browser/sessions/tab_restore_service_helper.cc:229:
web_contents.resize(1);
Assuming no one else modifies web_contents before this is a bit fragile. Declare
a local then use push_back as you don on 258. Same comment at 273.

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
File chrome/browser/sessions/tab_restore_service_helper.h (right):

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
chrome/browser/sessions/tab_restore_service_helper.h:140: content::WebContents**
contents);
Document |contents|.

[Kristen Dwan, 2013-08-05 18:01:37]

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/persi...
File chrome/browser/sessions/persistent_tab_restore_service.cc (right):

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/persi...
chrome/browser/sessions/persistent_tab_restore_service.cc:946:
PersistentTabRestoreService::RestoreMostRecentEntry(
On 2013/08/05 16:16:17, sky wrote:
> nit: don't indent this 4. Either none or 2 (not sure which). The following two
> lines should be 4 space indented. Same comment for 958-962.

Done.

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/sessi...
File chrome/browser/sessions/session_restore_browsertest.cc (right):

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/sessi...
chrome/browser/sessions/session_restore_browsertest.cc:372: EXPECT_EQ(1U,
content.size());
On 2013/08/05 16:16:17, sky wrote:
> This should be an assert. As if the size isn't 1, then 373 would crash
(assuming
> content is empty).

Done.

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/sessi...
chrome/browser/sessions/session_restore_browsertest.cc:424: EXPECT_EQ(1U,
content.size());
On 2013/08/05 16:16:17, sky wrote:
> ASSERT

Done.

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
File chrome/browser/sessions/tab_restore_service_helper.cc (right):

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
chrome/browser/sessions/tab_restore_service_helper.cc:174:
TabRestoreServiceHelper::RestoreMostRecentEntry(
On 2013/08/05 16:16:17, sky wrote:
> Same indentation comment.

Done.

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
chrome/browser/sessions/tab_restore_service_helper.cc:229:
web_contents.resize(1);
On 2013/08/05 16:16:17, sky wrote:
> Assuming no one else modifies web_contents before this is a bit fragile.
Declare
> a local then use push_back as you don on 258. Same comment at 273.

Done.

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
File chrome/browser/sessions/tab_restore_service_helper.h (right):

https://codereview.chromium.org/21656002/diff/1/chrome/browser/sessions/tab_r...
chrome/browser/sessions/tab_restore_service_helper.h:140: content::WebContents**
contents);
On 2013/08/05 16:16:17, sky wrote:
> Document |contents|.

Done.

[sky, 2013-08-05 19:50:56]

LGTM

[Kristen Dwan, 2013-08-06 14:44:56]

missed updating the overrides in *in_memory_tab_restore_service* and
*session_restore_android* so had conflicting return types .. sorry -- ptal,
thanks!

[sky, 2013-08-06 16:44:01]

SLGTM

[commit-bot: I haz the power, 2013-08-06 16:47:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dwankri@chromium.org/21656002/39001

[commit-bot: I haz the power, 2013-08-06 19:47:00]

Change committed as 215953