Issue 21646002: Rename enum in StoragePartition according to style guide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21646002: Rename enum in StoragePartition according to style guide. (Closed)

Created:
7 years, 4 months ago by lazyboy

Modified:
7 years, 4 months ago

Reviewers:
jam, mkosiba (inactive)

CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Rename enum in StoragePartition according to style guide. Enums should have ALL_CAPS with enum name as prefix, according to style guide. BUG=None Test=Rename only change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215344

Patch Set 1 #

Patch Set 2 : Remove the TODO. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -16 lines)			Patch
M	android_webview/native/aw_quota_manager_bridge_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_remover.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/data_deleter.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/storage_partition_impl.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/storage_partition_impl_map.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/storage_partition_impl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/storage_partition.h	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

lazyboy

mkosiba@ for android_webview/* jam@ for rest. This come up while John was reviewing another CL.

7 years, 4 months ago (2013-08-01 23:09:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/21646002/3001

7 years, 4 months ago (2013-08-02 17:07:58 UTC) #4

Message was sent while issue was closed.

Change committed as 215344

Expand Messages | Collapse Messages