Refactoring: Hide or remove some methods of Resource

Refactoring: Hide or remove some methods of Resource

This CL hides or removes some methods of Resource for code health.

There was only one usage of resourceTypeName, which was removed at
crrev.com/1889973002.

BUG=n/a

Committed: https://crrev.com/d8232ee902862b691d958d5cc66670a8fd9f4e0c
Cr-Commit-Position: refs/heads/master@{#406513}

[hajimehoshi, 2016-07-19 08:17:17]

hajimehoshi@chromium.org changed reviewers:
+ hiroshige@chromium.org, mkwst@chromium.org

[hajimehoshi, 2016-07-19 08:17:17]

PTAL

[hiroshige, 2016-07-19 08:20:05]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 08:20:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-07-19 08:30:20]

https://codereview.chromium.org/2164553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.h (right):

https://codereview.chromium.org/2164553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.h:291: unsigned count() const {
return m_clients.size(); }
We can remove count() by replacing |count()| with |clients().size()| at the only
callsite of count() in RawResource.
Or we should rename count() to clientCount() or something that explicitly states
that this is the count of clients, not including observers.

[hajimehoshi, 2016-07-19 08:51:16]

Thank you!

https://codereview.chromium.org/2164553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.h (right):

https://codereview.chromium.org/2164553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.h:291: unsigned count() const {
return m_clients.size(); }
On 2016/07/19 08:30:19, hiroshige wrote:
> We can remove count() by replacing |count()| with |clients().size()| at the
only
> callsite of count() in RawResource.
> Or we should rename count() to clientCount() or something that explicitly
states
> that this is the count of clients, not including observers.

Done.

[hajimehoshi, 2016-07-19 08:51:49]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 08:52:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-07-19 09:19:38]

lgtm

[commit-bot: I haz the power, 2016-07-19 12:30:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 12:30:56]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-07-19 12:46:21]

Deleting code! \o/

LGTM.

[hajimehoshi, 2016-07-20 06:06:16]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-07-20 06:06:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2164553002/#ps40001
(title: "(rebase)")

[commit-bot: I haz the power, 2016-07-20 06:06:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 07:41:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-20 07:42:41]

Description was changed from

==========
Refactoring: Hide or remove some methods of Resource

This CL hides or removes some methods of Resource for code health.

There was only one usage of resourceTypeName, which was removed at
crrev.com/1889973002.

BUG=n/a
==========

to

==========
Refactoring: Hide or remove some methods of Resource

This CL hides or removes some methods of Resource for code health.

There was only one usage of resourceTypeName, which was removed at
crrev.com/1889973002.

BUG=n/a

Committed: https://crrev.com/d8232ee902862b691d958d5cc66670a8fd9f4e0c
Cr-Commit-Position: refs/heads/master@{#406513}
==========

[commit-bot: I haz the power, 2016-07-20 07:42:42]

Patchset 3 (id:??) landed as
https://crrev.com/d8232ee902862b691d958d5cc66670a8fd9f4e0c
Cr-Commit-Position: refs/heads/master@{#406513}