Issue 21629002: Supports changing resolutions from options UI page.

Issue 21629002: Supports changing resolutions from options UI page. (Closed)

Created:
7 years, 4 months ago by Jun Mukai

Modified:
7 years, 4 months ago

Reviewers:
oshima

CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Supports changing resolutions from options UI page. It should have a confirmation dialog for the resolution change for the safety. It will be done in another CL. BUG=266097 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215255

Patch Set 1 #

Patch Set 2 : polish #

Total comments: 2

Patch Set 3 : fix #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -39 lines)			Patch
M	chrome/browser/resources/options/chromeos/display_options.js	View	1	3 chunks	+16 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/display_options_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/display_options_handler.cc	View	1 2	5 chunks	+79 lines, -29 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm https://codereview.chromium.org/21629002/diff/3001/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (right): https://codereview.chromium.org/21629002/diff/3001/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc#newcode334 chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:334: LOG(ERROR) << display_id; remove this?

7 years, 4 months ago (2013-08-01 22:50:44 UTC) #2

Jun Mukai

https://codereview.chromium.org/21629002/diff/3001/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (right): https://codereview.chromium.org/21629002/diff/3001/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc#newcode334 chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:334: LOG(ERROR) << display_id; On 2013/08/01 22:50:44, oshima wrote: > ...

7 years, 4 months ago (2013-08-02 01:35:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/21629002/8001

7 years, 4 months ago (2013-08-02 01:35:40 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-02 01:45:54 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/21629002/8001

7 years, 4 months ago (2013-08-02 01:47:29 UTC) #6

Message was sent while issue was closed.

Change committed as 215255

Expand Messages | Collapse Messages