Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Side by Side Diff: Source/core/css/resolver/StyleBuilder.h

Issue 21625003: StyleBuilder should not know about StyleResolver. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 #ifndef StyleBuilder_h 31 #ifndef StyleBuilder_h
32 #define StyleBuilder_h 32 #define StyleBuilder_h
33 33
34 #include "CSSPropertyNames.h" 34 #include "CSSPropertyNames.h"
35 35
36 namespace WebCore { 36 namespace WebCore {
37 37
38 class CSSValue; 38 class CSSValue;
39 class Document; 39 class Document;
40 class RenderStyle; 40 class RenderStyle;
41 class StyleResolver;
42 class StyleResolverState; 41 class StyleResolverState;
43 42
44 class StyleBuilder { 43 class StyleBuilder {
45 public: 44 public:
46 static bool applyProperty(CSSPropertyID, StyleResolver*, StyleResolverState& , CSSValue*, bool isInitial, bool isInherit); 45 static void applyProperty(CSSPropertyID, StyleResolverState&, CSSValue*);
47 46
48 // This function contains the gigantic old switch-statement of properties in herited from 47 // This function contains the gigantic old switch-statement of properties in herited from
49 // StyleResolver. Each property should be migrated over to a new StyleBuilde r templated 48 // StyleResolver. Each property should be migrated over to a new StyleBuilde r templated
50 // function and removed from this code. Once they're all moved, this functio n can die. 49 // function and removed from this code. Once they're all moved, this functio n can die.
51 static void oldApplyProperty(CSSPropertyID, StyleResolver*, StyleResolverSta te&, CSSValue*, bool isInitial, bool isInherit); 50 static void oldApplyProperty(CSSPropertyID, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);
51
52 private:
53 static bool applyProperty(CSSPropertyID, StyleResolverState&, CSSValue*, boo l isInitial, bool isInherit);
52 }; 54 };
53 55
54 } 56 }
55 57
56 #endif 58 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698