Added Ash.SystemMenu.DefaultView.VisibleItems histogram.

ash/common/system/tray/system_tray_item.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SYSTEM_TRAY_SYSTEM_TRAY_ITEM_H_
 #define ASH_COMMON_SYSTEM_TRAY_SYSTEM_TRAY_ITEM_H_
 
 #include "ash/ash_export.h"
 #include "ash/common/login_status.h"
 #include "ash/common/shelf/shelf_types.h"
 #include "base/macros.h"
 
 namespace views {
 class View;
 }
 
 namespace ash {
 class SystemTray;
 class TrayItemView;
 
 class ASH_EXPORT SystemTrayItem {
  public:
-  explicit SystemTrayItem(SystemTray* system_tray);
+  // The different types of SystemTrayItems.
+  //
+  // *** IMPORTANT *** - These values are used for UMA metrics so do NOT
+  // re-order
+  // this enum and only insert items before the COUNT item.

[tdanderson, 2016/07/19 21:58:40]

nit: awkward line break.

[bruthig, 2016/07/20 18:15:52]

Done.

+  enum ItemType {
+    ACCESSIBILITY,         // 0

[tdanderson, 2016/07/19 21:58:40]

Consider making UNKNOWN/NONE the 0-element, and use that in unittests rather
than NETWORK.

[bruthig, 2016/07/20 18:15:52]

Added TEST at 0.

+    AUDIO,                 // 1
+    BLUETOOTH,             // 2
+    CAPS_LOCK,             // 3
+    CAST,                  // 4
+    DATE_POWER_LOCK,       // 5
+    DISPLAY,               // 6
+    DISPLAY_BRIGHTNESS,    // 7
+    ENTERPRISE,            // 8
+    IME,                   // 9
+    MULTI_PROFILE_MEDIA,   // 10
+    NETWORK,               // 11
+    OS_SETTINGS,           // 12
+    OS_UPDATE,             // 13
+    POWER,                 // 14
+    ROTATION_LOCK,         // 15
+    SCREEN_CAPTURE,        // 16
+    SCREEN_SHARE,          // 17
+    SESSION_LENGTH_LIMIT,  // 18
+    SMS,                   // 19
+    SUPERVISED_USER,       // 20
+    TRACING,               // 21
+    USER,                  // 22
+    USER_SEPARATOR,        // 23
+    VPN,                   // 24
+    COUNT                  // 25
+  };
+
+  SystemTrayItem(SystemTray* system_tray, ItemType type);
   virtual ~SystemTrayItem();
 
+  ItemType type() const { return item_type_; }

[tdanderson, 2016/07/19 21:58:40]

I'm a bit concerned that having a public type() in SystemTrayItem may lead to
future misuse (e.g., someone calling type() and performing a static_cast when
inappropriate). At the very least maybe we want to call this something like
type_for_uma(), and perhaps make it private (and friend the caller). WDYT?

[bruthig, 2016/07/20 18:15:52]

Renamed ItemType as UmaType, moved uma_type() to private visibility and friended
SystemTrayBubble.

+
   // Create* functions may return NULL if nothing should be displayed for the
   // type of view. The default implementations return NULL.
 
   // Returns a view to be displayed in the system tray. If this returns NULL,
   // then this item is not displayed in the tray.
   // NOTE: The returned view should almost always be a TrayItemView, which
   // automatically resizes the widget when the size of the view changes, and
   // adds animation when the visibility of the view changes. If a view wants to
   // avoid this behavior, then it should not be a TrayItemView.
   virtual views::View* CreateTrayView(LoginStatus status);
@@ skipping 65 matching lines @@
   virtual bool ShouldShowShelf() const;
 
   // Returns the system tray that this item belongs to.
   SystemTray* system_tray() const { return system_tray_; }
 
   bool restore_focus() const { return restore_focus_; }
   void set_restore_focus(bool restore_focus) { restore_focus_ = restore_focus; }
 
  private:
   SystemTray* system_tray_;
+  ItemType item_type_;
   bool restore_focus_;
 
   DISALLOW_COPY_AND_ASSIGN(SystemTrayItem);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SYSTEM_TRAY_SYSTEM_TRAY_ITEM_H_