Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: Source/devtools/front_end/SourcesSearchScope.js

Issue 216183003: DevTools: Make sure UISC content is up-to-date when running performSearchInContent() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/UISourceCode.js » ('j') | Source/devtools/front_end/UISourceCode.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/SourcesSearchScope.js
diff --git a/Source/devtools/front_end/SourcesSearchScope.js b/Source/devtools/front_end/SourcesSearchScope.js
index 60f731164a95c323543f118aa35c848b29825ea7..f18564dc9b15a987e2f359b525e47eea33356a11 100644
--- a/Source/devtools/front_end/SourcesSearchScope.js
+++ b/Source/devtools/front_end/SourcesSearchScope.js
@@ -115,6 +115,8 @@ WebInspector.SourcesSearchScope.prototype = {
return;
}
+ addDirtyFiles();
+
if (!files.length) {
progress.done();
callback();
@@ -130,6 +132,34 @@ WebInspector.SourcesSearchScope.prototype = {
for (var i = 0; i < maxFileContentRequests && i < files.length; ++i)
scheduleSearchInNextFileOrFinish.call(this);
+ function addDirtyFiles()
+ {
+ var matchingFiles = new StringSet();
+ files.forEach(function(file) {
+ matchingFiles.put(file);
vsevik 2014/03/28 16:18:36 Can we use matchingFiles.put.bind(matchingFiles) i
apavlov 2014/03/30 13:02:09 Done.
+ });
+
+ project.uiSourceCodes().filter(dirtySourceCodeFilter).forEach(appendFilePath);
+
+ /**
+ * @param {!WebInspector.UISourceCode} sourceCode
vsevik 2014/03/28 16:18:36 s/sourceCode/uiSourceCode
apavlov 2014/03/30 13:02:09 Saw sourceCode somewhere
+ */
+ function dirtySourceCodeFilter(sourceCode)
+ {
+ return sourceCode.isDirty();
+ }
+
+ /**
+ * @param {!WebInspector.UISourceCode} sourceCode
+ */
+ function appendFilePath(sourceCode)
+ {
+ var path = sourceCode.path();
+ if (!matchingFiles.contains(path))
+ files.push(path);
+ }
+ }
+
/**
* @param {!string} path
* @this {WebInspector.SourcesSearchScope}
@@ -143,7 +173,19 @@ WebInspector.SourcesSearchScope.prototype = {
scheduleSearchInNextFileOrFinish.call(this);
return;
}
- uiSourceCode.requestContent(contentLoaded.bind(this, path));
+ if (uiSourceCode.isDirty())
+ contentLoaded.call(this, uiSourceCode.path(), uiSourceCode.workingCopy());
+ else
+ uiSourceCode.checkContentUpdated(contentUpdated.bind(this, uiSourceCode));
+ }
+
+ /**
+ * @param {!WebInspector.UISourceCode} uiSourceCode
+ * @this {WebInspector.SourcesSearchScope}
+ */
+ function contentUpdated(uiSourceCode)
+ {
+ uiSourceCode.requestContent(contentLoaded.bind(this, uiSourceCode.path()));
}
/**
« no previous file with comments | « no previous file | Source/devtools/front_end/UISourceCode.js » ('j') | Source/devtools/front_end/UISourceCode.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698