Prepared newlib toolchain for socket implementation

Prepared newlib toolchain for socket implementation

Now that appropriate socket headers have been found for newlib,
two things need to be done before socket implementation work can begin.
First, wrappers must be added to kernel_wrap_newlib. Second, some
helper functions provided by glibc need to be implemented. This CL
does both. In particular, inet_ntoa() and inet_ntop() have been
implemented, allowing the conversion of IPv4 and IPv6 addresses
to strings.

NOTRY=true
BUG=None
TEST=None
R=noelallen@chromium.org,bradnelson@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215937

[Sam Clegg, 2013-08-01 20:50:53]

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
File native_client_sdk/src/libraries/nacl_io/inet_ntoa.cc (right):

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/inet_ntoa.cc:1: #include <arpa/inet.h>
Missing copyright.

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/inet_ntoa.cc:12: static inline uint8_t
get_byte(const void *addr, int byte) {
We use the "char* " rather than "char *" style.

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/inet_ntoa.cc:17: char *inet_ntoa(struct
in_addr in) {
Are these functions missing under glibc?  If not maybe these functions should be
newlib only?

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
File native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc (right):

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc:223: // Socket
functions
duplicate line

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc:279: socklen_t
len) {
alignment.

[torinmr, 2013-08-01 22:04:00]

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
File native_client_sdk/src/libraries/nacl_io/inet_ntoa.cc (right):

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/inet_ntoa.cc:1: #include <arpa/inet.h>
On 2013/08/01 20:50:53, Sam Clegg wrote:
> Missing copyright.

Done.

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/inet_ntoa.cc:12: static inline uint8_t
get_byte(const void *addr, int byte) {
On 2013/08/01 20:50:53, Sam Clegg wrote:
> We use the "char* " rather than "char *" style.

Done.

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
File native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc (right):

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc:223: // Socket
functions
On 2013/08/01 20:50:53, Sam Clegg wrote:
> duplicate line

Done.

https://chromiumcodereview.appspot.com/21610003/diff/3001/native_client_sdk/s...
native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc:279: socklen_t
len) {
On 2013/08/01 20:50:53, Sam Clegg wrote:
> alignment.

Done.

[Sam Clegg, 2013-08-06 00:33:40]

lgtm

[commit-bot: I haz the power, 2013-08-06 18:42:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torinmr@chromium.org/21610003/39001

[commit-bot: I haz the power, 2013-08-06 18:43:14]

Change committed as 215937