tools/dom/scripts/htmleventgenerator.py - Issue 21607003: Add Event delegation to Elements and groups of elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmleventgenerator.py

Issue 21607003: Add Event delegation to Elements and groups of elements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/htmleventgenerator.py

diff --git a/tools/dom/scripts/htmleventgenerator.py b/tools/dom/scripts/htmleventgenerator.py

index b6566afec89f12b1c67c76d2517e94db65082670..114c1f20ec27d91d48823619eb2c3c54d7baa41d 100644

--- a/tools/dom/scripts/htmleventgenerator.py

+++ b/tools/dom/scripts/htmleventgenerator.py

@@ -291,11 +291,14 @@ class HtmlEventGenerator(object):

annotations = self._metadata.GetFormattedMetadata(

library_name, interface, annotation_name, ' ')

+ isElement = ('Element' in interface.id and

blois 2013/08/02 20:13:02 Shouldn't all element subclasses get this? Not jus

Emily Fortuna 2013/08/07 23:38:25 Done.

+ 'ElementInstance' not in interface.id)

members_emitter.Emit(

"\n"

- " $(ANNOTATIONS)Stream<$TYPE> get $(NAME) => "

- "$PROVIDER.forTarget(this);\n",

+ " $(ANNOTATIONS)$(ELEM_TYPE)Stream<$TYPE> get $(NAME) => "

+ "$PROVIDER.for$(ELEM_TYPE)Target(this);\n",

ANNOTATIONS=annotations,

+ ELEM_TYPE='Element' if isElement else '',

NAME=getter_name,

PROVIDER=provider,

TYPE=event_type)

« no previous file with comments | « tests/html/element_test.dart ('k') | tools/dom/src/EventStreamProvider.dart » ('j') | tools/dom/src/EventStreamProvider.dart » ('J')