Add json responseType support to XMLHttpRequest

Add json responseType support to XMLHttpRequest

BUG=119256
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156290

[jochen (gone - plz use gerrit), 2013-08-05 08:41:33]

the JSON extension won't be available on workers. Is this intended?

[tyoshino (SeeGerritForStatus), 2013-08-05 11:04:49]

On 2013/08/05 08:41:33, jochen wrote:
> the JSON extension won't be available on workers. Is this intended?

Maybe we can run this for workers by making change on
WorkerScriptController::initializeContextIfNeeded()?

jochen's patch exporting parser from v8
https://codereview.chromium.org/21959003/

[abarth-chromium, 2013-08-05 22:11:22]

Looks like we should wait for the real JSON API.

[tyoshino (SeeGerritForStatus), 2013-08-06 03:40:21]

On 2013/08/05 22:11:22, abarth wrote:
> Looks like we should wait for the real JSON API.

Yes. I'll rewrite the patch to use jochen's work.

[tyoshino (SeeGerritForStatus), 2013-08-06 18:35:32]

Updated to use v8::JSON::Parse.

Depends on
https://codereview.chromium.org/22416003/

[abarth-chromium, 2013-08-06 19:28:32]

lgtm

https://codereview.chromium.org/21600002/diff/9001/Source/bindings/v8/custom/...
File Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp (right):

https://codereview.chromium.org/21600002/diff/9001/Source/bindings/v8/custom/...
Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:95: case
XMLHttpRequest::ResponseTypeJson:
ResponseTypeJson -> ResponseTypeJSON

https://codereview.chromium.org/21600002/diff/9001/Source/bindings/v8/custom/...
Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:98: ScriptString jsonSource
= xmlHttpRequest->responseJsonSource(es);
responseJsonSource -> responseJSONSource

https://codereview.chromium.org/21600002/diff/9001/Source/bindings/v8/custom/...
Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:102: v8::Isolate* isolate =
info.GetIsolate();
Should we grab the isolate at the top of the block instead of calling GetIsolate
twice?

[tyoshino (SeeGerritForStatus), 2013-08-07 03:37:45]

Thanks. I'll submit this when the fix for JSON::Parse is landed, merged into v8
trunk, and is rolled to Chromium.

https://codereview.chromium.org/21600002/diff/9001/Source/bindings/v8/custom/...
File Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp (right):

https://codereview.chromium.org/21600002/diff/9001/Source/bindings/v8/custom/...
Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:95: case
XMLHttpRequest::ResponseTypeJson:
On 2013/08/06 19:28:33, abarth wrote:
> ResponseTypeJson -> ResponseTypeJSON

Done.

https://codereview.chromium.org/21600002/diff/9001/Source/bindings/v8/custom/...
Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:98: ScriptString jsonSource
= xmlHttpRequest->responseJsonSource(es);
On 2013/08/06 19:28:33, abarth wrote:
> responseJsonSource -> responseJSONSource

Done.

https://codereview.chromium.org/21600002/diff/9001/Source/bindings/v8/custom/...
Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:102: v8::Isolate* isolate =
info.GetIsolate();
On 2013/08/06 19:28:33, abarth wrote:
> Should we grab the isolate at the top of the block instead of calling
GetIsolate
> twice?

Yes! Done

[tyoshino (SeeGerritForStatus), 2013-08-19 07:40:57]

On 2013/08/07 03:37:45, tyoshino wrote:
> Thanks. I'll submit this when the fix for JSON::Parse is landed, merged into
v8
> trunk, and is rolled to Chromium.

It's merged into trunk and rolled into Chromium. Layout tests are still passing.

Submitting.

[commit-bot: I haz the power, 2013-08-19 07:41:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/21600002/15001

[commit-bot: I haz the power, 2013-08-19 08:09:10]

Change committed as 156290