net: make CanonicalCookie's constructor private

ios/net/cookies/cookie_store_ios_unittest.mm

Index: ios/net/cookies/cookie_store_ios_unittest.mm
diff --git a/ios/net/cookies/cookie_store_ios_unittest.mm b/ios/net/cookies/cookie_store_ios_unittest.mm
index d709910ed6794047ddf55de63fcc2986923feb47..d2a92b107a5bbc732aaa8f411dc60c0f6880fddb 100644
--- a/ios/net/cookies/cookie_store_ios_unittest.mm
+++ b/ios/net/cookies/cookie_store_ios_unittest.mm
@@ -259,16 +259,17 @@ class TestPersistentCookieStore
 
     // Some canonical cookies cannot be converted into System cookies, for
     // example if value is not valid utf8. Such cookies are ignored.
-    net::CanonicalCookie* bad_canonical_cookie = new net::CanonicalCookie(
-        kTestCookieURL, "name", "\x81r\xe4\xbd\xa0\xe5\xa5\xbd", "domain",
-        "path/",
-        base::Time(),  // creation
-        base::Time(),  // expires
-        base::Time(),  // last_access
-        false,         // secure
-        false,         // httponly
-        net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT);
-    cookies.push_back(bad_canonical_cookie);
+    std::unique_ptr<net::CanonicalCookie> bad_canonical_cookie(
+        net::CanonicalCookie::Create(GURL("http://domain"), "name",

[droger, 2016/07/22 08:58:10]

Is this now returning NULL?

Could it be because the domain is the empty string?

[tfarina, 2016/07/22 12:37:15]

I added it back but I think it still returns NULL. Matt, could you advise here
what is the right fix for creating a bad canonical cookie?

[mmenke, 2016/07/22 14:52:44]

I think the path is invalid - it needs a leading slash (i.e. "/path/").  Code so
often creating invalid cookies is just the reason for switching to the
validating constructor.

[tfarina, 2016/07/22 19:50:01]

Thanks Matt! ios_net_unittests is green again with this.

+                                     "\x81r\xe4\xbd\xa0\xe5\xa5\xbd",
+                                     std::string(), "path/",
+                                     base::Time(),  // creation
+                                     base::Time(),  // expires
+                                     false,         // secure
+                                     false,         // httponly
+                                     net::CookieSameSite::DEFAULT_MODE, false,
+                                     net::COOKIE_PRIORITY_DEFAULT));
+    cookies.push_back(bad_canonical_cookie.release());
     loaded_callback_.Run(cookies);
   }