Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 21591002: Enable Device Motion on Android by default. (Closed)

Created:
7 years, 4 months ago by timvolodine
Modified:
7 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable Device Motion on Android by default. This CL: - enables Device Motion by default on the Android platform. - adds a disable-device-motion flag. BUG=135804 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215215

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
timvolodine
7 years, 4 months ago (2013-08-01 17:35:14 UTC) #1
timvolodine
Hi Adam, Clank PMs want this flag enabled for tomorrows go/no-go meeting.. thanks, Tim
7 years, 4 months ago (2013-08-01 18:01:25 UTC) #2
Miguel Garcia
On 2013/08/01 18:01:25, timvolodine wrote: > Hi Adam, > > Clank PMs want this flag ...
7 years, 4 months ago (2013-08-01 18:41:45 UTC) #3
abarth-chromium
I'm not an OWNER here...
7 years, 4 months ago (2013-08-01 20:53:36 UTC) #4
abarth-chromium
This change itself is fine with me.
7 years, 4 months ago (2013-08-01 20:54:07 UTC) #5
timvolodine
Antoine, please have a look. thanks, Tim
7 years, 4 months ago (2013-08-01 22:11:49 UTC) #6
piman
lgtm
7 years, 4 months ago (2013-08-01 22:16:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/21591002/10001
7 years, 4 months ago (2013-08-01 22:24:17 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-02 04:44:05 UTC) #9
Message was sent while issue was closed.
Change committed as 215215

Powered by Google App Engine
This is Rietveld 408576698