Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Issue 21584002: Delete dead code: OmxVideoDecodeAccelerator is unused. (Closed)

Created:
7 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
7 years, 4 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Pawel Osciak, sheu
Visibility:
Public.

Description

Delete dead code: OmxVideoDecodeAccelerator is unused. OVDA has been dead code in the tree since 3/13 and m27 https://gerrit.chromium.org/gerrit/gitweb?p=chromiumos/platform/login_manager.git;a=commit;h=934e55cd90c2fd7a5b89fe201b251d542e896f46 BUG=223194 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215933

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reviving third_party/openmax/OWNERS to avoid presubmit barfage. #

Patch Set 3 : Revived third_party/openmax/README.chromium for check_licenses. #

Patch Set 4 : Re-removing both OWNERS & README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8534 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/gpu/media/gles2_texture_to_egl_image_translator.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/common/gpu/media/gles2_texture_to_egl_image_translator.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +5 lines, -14 lines 0 comments Download
D content/common/gpu/media/omx_video_decode_accelerator.h View 1 chunk +0 lines, -279 lines 0 comments Download
D content/common/gpu/media/omx_video_decode_accelerator.cc View 1 chunk +0 lines, -1259 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/content_gpu.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/openmax/OWNERS View 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/openmax/README.chromium View 3 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/openmax/il.sigs View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/openmax/il/LICENSE View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/openmax/il/OMX_Audio.h View 1 chunk +0 lines, -1311 lines 0 comments Download
D third_party/openmax/il/OMX_Component.h View 1 chunk +0 lines, -579 lines 0 comments Download
D third_party/openmax/il/OMX_ContentPipe.h View 1 chunk +0 lines, -195 lines 0 comments Download
D third_party/openmax/il/OMX_Core.h View 1 chunk +0 lines, -1431 lines 0 comments Download
D third_party/openmax/il/OMX_IVCommon.h View 1 chunk +0 lines, -920 lines 0 comments Download
D third_party/openmax/il/OMX_Image.h View 1 chunk +0 lines, -328 lines 0 comments Download
D third_party/openmax/il/OMX_Index.h View 1 chunk +0 lines, -258 lines 0 comments Download
D third_party/openmax/il/OMX_Other.h View 1 chunk +0 lines, -337 lines 0 comments Download
D third_party/openmax/il/OMX_Types.h View 1 chunk +0 lines, -347 lines 0 comments Download
D third_party/openmax/il/OMX_Video.h View 1 chunk +0 lines, -1060 lines 0 comments Download
D third_party/openmax/il_stub_headers.fragment View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Ami GONE FROM CHROMIUM
piman: since the changes are fairly trivial and I need your OWNERS review anyway, please ...
7 years, 4 months ago (2013-08-01 17:07:47 UTC) #1
scherkus (not reviewing)
\o/ https://codereview.chromium.org/21584002/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (left): https://codereview.chromium.org/21584002/diff/1/content/public/common/content_switches.cc#oldcode871 content/public/common/content_switches.cc:871: const char kUseExynosVda[] = "use-exynos-vda"; is there a ...
7 years, 4 months ago (2013-08-01 18:15:56 UTC) #2
sheu
https://codereview.chromium.org/21584002/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (left): https://codereview.chromium.org/21584002/diff/1/content/public/common/content_switches.cc#oldcode871 content/public/common/content_switches.cc:871: const char kUseExynosVda[] = "use-exynos-vda"; On 2013/08/01 18:15:56, scherkus ...
7 years, 4 months ago (2013-08-01 18:18:11 UTC) #3
scherkus (not reviewing)
On 2013/08/01 18:18:11, sheu wrote: > https://codereview.chromium.org/21584002/diff/1/content/public/common/content_switches.cc > File content/public/common/content_switches.cc (left): > > https://codereview.chromium.org/21584002/diff/1/content/public/common/content_switches.cc#oldcode871 > ...
7 years, 4 months ago (2013-08-01 18:19:38 UTC) #4
Ami GONE FROM CHROMIUM
No barf, need to wait for this to land and roll into chromeos before removing ...
7 years, 4 months ago (2013-08-01 18:33:09 UTC) #5
piman
lgtm
7 years, 4 months ago (2013-08-02 19:11:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/21584002/1
7 years, 4 months ago (2013-08-05 20:06:36 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=18817
7 years, 4 months ago (2013-08-05 20:24:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/21584002/22001
7 years, 4 months ago (2013-08-05 20:29:13 UTC) #9
Ami GONE FROM CHROMIUM
Trying PS#2 whose only delta to PS#1 is that it does _not_ remove third_party/openmax/OWNERS, because ...
7 years, 4 months ago (2013-08-05 20:29:20 UTC) #10
Ami GONE FROM CHROMIUM
> If CQ is happy with this then I'll file a bug about the above. ...
7 years, 4 months ago (2013-08-05 20:43:20 UTC) #11
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=90686
7 years, 4 months ago (2013-08-05 21:46:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/21584002/43001
7 years, 4 months ago (2013-08-05 23:47:49 UTC) #13
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=90792
7 years, 4 months ago (2013-08-06 01:22:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/21584002/58001
7 years, 4 months ago (2013-08-06 18:10:28 UTC) #15
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 18:11:43 UTC) #16
Message was sent while issue was closed.
Change committed as 215933

Powered by Google App Engine
This is Rietveld 408576698