Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2913)

Unified Diff: chrome/browser/prefs/synced_pref_change_registrar.cc

Issue 21580002: Add histograms to track synced pref changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix dynamic histograms and test cleanup Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/synced_pref_change_registrar.cc
diff --git a/chrome/browser/prefs/synced_pref_change_registrar.cc b/chrome/browser/prefs/synced_pref_change_registrar.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3101210cb8f234565133887e638022414423ac9f
--- /dev/null
+++ b/chrome/browser/prefs/synced_pref_change_registrar.cc
@@ -0,0 +1,66 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/prefs/synced_pref_change_registrar.h"
+
+#include "base/bind.h"
+
+namespace {
+
+void InvokeUnnamedCallback(
+ const SyncedPrefChangeRegistrar::ChangeCallback& callback,
+ const std::string& path,
+ bool from_sync) {
+ callback.Run(from_sync);
+}
+
+} // namespace
+
+SyncedPrefChangeRegistrar::SyncedPrefChangeRegistrar(
+ PrefServiceSyncable* pref_service) {
+ pref_service_ = pref_service;
+}
+
+SyncedPrefChangeRegistrar::~SyncedPrefChangeRegistrar() {
+ RemoveAll();
+}
+
+void SyncedPrefChangeRegistrar::Add(const char *path,
+ const ChangeCallback& callback) {
+ Add(path, base::Bind(InvokeUnnamedCallback, callback));
+}
+
+void SyncedPrefChangeRegistrar::Add(const char *path,
+ const NamedChangeCallback& callback) {
+ DCHECK(!IsObserved(path));
+ observers_[path] = callback;
+ pref_service_->AddSyncedPrefObserver(path, this);
+}
+
+void SyncedPrefChangeRegistrar::Remove(const char *path) {
+ observers_.erase(path);
+ pref_service_->RemoveSyncedPrefObserver(path, this);
+}
+
+void SyncedPrefChangeRegistrar::RemoveAll() {
+ for (ObserverMap::iterator iter = observers_.begin();
+ iter != observers_.end(); ++iter) {
+ pref_service_->RemoveSyncedPrefObserver(iter->first, this);
+ }
+ observers_.clear();
+}
+
+bool SyncedPrefChangeRegistrar::IsObserved(const char* path) const {
+ return observers_.find(path) != observers_.end();
+}
+
+void SyncedPrefChangeRegistrar::OnSyncedPrefChanged(const std::string& path,
+ bool from_sync) {
+ if (pref_service_->IsManagedPreference(path.c_str()))
+ return;
+ ObserverMap::const_iterator iter = observers_.find(path);
+ if (iter == observers_.end())
+ return;
+ iter->second.Run(path, from_sync);
+}
« no previous file with comments | « chrome/browser/prefs/synced_pref_change_registrar.h ('k') | chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698