Added 3-color gradient scraper for detecting symmetrical gradients.

Added 3-color gradient scraper for detecting symmetrical gradients.





Made changes to lua to scrape info about 3 color gradients

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=10490

[reed1, 2013-08-01 16:00:10]

https://codereview.chromium.org/21571002/diff/1/src/utils/SkLua.cpp
File src/utils/SkLua.cpp (right):

https://codereview.chromium.org/21571002/diff/1/src/utils/SkLua.cpp#newcode717
src/utils/SkLua.cpp:717: SkScalar pos[3];    // can get data for all gradient
types by calling asAGradient twice
not sure what this comment means. all types? do we need this comment?

https://codereview.chromium.org/21571002/diff/1/src/utils/SkLua.cpp#newcode729
src/utils/SkLua.cpp:729: setfield_number(L, "mid", pos[1]);
Should we add this field if colorCount != 3 ?

Perhaps a more descriptive field name?

https://codereview.chromium.org/21571002/diff/1/tools/lua/gradients.lua
File tools/lua/gradients.lua (right):

https://codereview.chromium.org/21571002/diff/1/tools/lua/gradients.lua#newco...
tools/lua/gradients.lua:21: if g.mid == 0.5 then
I wonder if we need a little slop here... [0.499 ... 0.501].

[dierk, 2013-08-01 16:07:39]

https://codereview.chromium.org/21571002/diff/1/src/utils/SkLua.cpp
File src/utils/SkLua.cpp (right):

https://codereview.chromium.org/21571002/diff/1/src/utils/SkLua.cpp#newcode717
src/utils/SkLua.cpp:717: SkScalar pos[3];    // can get data for all gradient
types by calling asAGradient twice
On 2013/08/01 16:00:10, reed1 wrote:
> not sure what this comment means. all types? do we need this comment?

Done.

https://codereview.chromium.org/21571002/diff/1/src/utils/SkLua.cpp#newcode729
src/utils/SkLua.cpp:729: setfield_number(L, "mid", pos[1]);
On 2013/08/01 16:00:10, reed1 wrote:
> Should we add this field if colorCount != 3 ?
> 
> Perhaps a more descriptive field name?

Done.

https://codereview.chromium.org/21571002/diff/1/tools/lua/gradients.lua
File tools/lua/gradients.lua (right):

https://codereview.chromium.org/21571002/diff/1/tools/lua/gradients.lua#newco...
tools/lua/gradients.lua:21: if g.mid == 0.5 then
On 2013/08/01 16:00:10, reed1 wrote:
> I wonder if we need a little slop here... [0.499 ... 0.501].

Done.

[reed1, 2013-08-01 16:23:26]

lgtm

https://codereview.chromium.org/21571002/diff/6001/src/utils/SkLua.cpp
File src/utils/SkLua.cpp (right):

https://codereview.chromium.org/21571002/diff/6001/src/utils/SkLua.cpp#newcod...
src/utils/SkLua.cpp:731: if (info.fColorCount == 3){
nit: 3 == info.fColorCount

This ordering ensures you can't accidentally type 3 = info.fColorCount, which
would be assigning to a literal.

[commit-bot: I haz the power, 2013-08-01 17:15:54]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/dierk@google.com/21571002/6001

[commit-bot: I haz the power, 2013-08-01 17:32:58]

Change committed as 10490