chrome/browser/ui/browser.cc - Issue 2156113002: Replace AppBannerDataFetcher with InstallableManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 2156113002: Replace AppBannerDataFetcher with InstallableManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-refactor

Patch Set: Naming, includes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index b8ac90ba145840b5bc7746443cc37d7af4f6eba7..4a25e9dded5bdd8ef632e313d192844cc1462b55 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -36,7 +36,6 @@

#include "chrome/browser/background/background_contents_service.h"

#include "chrome/browser/background/background_contents_service_factory.h"

#include "chrome/browser/banners/app_banner_manager_desktop.h"

-#include "chrome/browser/banners/app_banner_manager_emulation.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/browser_shutdown.h"

#include "chrome/browser/character_encoding.h"

@@ -1349,9 +1348,9 @@ std::unique_ptr<content::BluetoothChooser> Browser::RunBluetoothChooser(

}

void Browser::RequestAppBannerFromDevTools(content::WebContents* web_contents) {

- banners::AppBannerManagerEmulation::CreateForWebContents(web_contents);

- banners::AppBannerManagerEmulation* manager =

- banners::AppBannerManagerEmulation::FromWebContents(web_contents);

+ banners::AppBannerManagerDesktop::CreateForWebContents(web_contents);

+ banners::AppBannerManagerDesktop* manager =

+ banners::AppBannerManagerDesktop::FromWebContents(web_contents);

manager->RequestAppBanner(web_contents->GetLastCommittedURL(), true);

}

« no previous file with comments | « chrome/browser/banners/app_banner_settings_helper.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »