chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java - Issue 2156113002: Replace AppBannerDataFetcher with InstallableManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2156113002: Replace AppBannerDataFetcher with InstallableManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-refactor

Patch Set: Naming, includes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java ('k') | chrome/browser/android/banners/app_banner_data_fetcher_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

index 16bd77d619dc808acf37e071a981bf2de241d59d..548801cd2dae804f022cdf0d7c6925b673a1b2ec 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

@@ -225,7 +225,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

public boolean isSatisfied() {

AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();

return mDetailsDelegate.mNumRetrieved == numExpected

- && !manager.isFetcherActiveForTesting();

+ && !manager.isActiveForTesting();

}

});

}

@@ -313,7 +313,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

@Override

public boolean isSatisfied() {

AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();

- return !manager.isFetcherActiveForTesting();

+ return !manager.isActiveForTesting();

}

});

waitUntilNoInfoBarsExist();

@@ -325,7 +325,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

@Override

public boolean isSatisfied() {

AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();

- return !manager.isFetcherActiveForTesting();

+ return !manager.isActiveForTesting();

}

});

waitUntilAppBannerInfoBarAppears(expectedTitle);

@@ -484,7 +484,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

@Override

public boolean isSatisfied() {

AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();

- return !manager.isFetcherActiveForTesting();

+ return !manager.isActiveForTesting();

}

});

waitUntilNoInfoBarsExist();

@@ -501,7 +501,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {

@Override

public boolean isSatisfied() {

AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();

- return !manager.isFetcherActiveForTesting();

+ return !manager.isActiveForTesting();

}

});

waitUntilAppBannerInfoBarAppears(WEB_APP_TITLE);