Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6596)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 2156113002: Replace AppBannerDataFetcher with InstallableManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-refactor
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index b3e0dea497d509976be38c1d550bda98792b6fab..d5a940929df2d62c74dd4c17b821719d24cb8ca6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -154,8 +154,8 @@ public class AppBannerManager {
/** Returns whether an AppBannerDataFetcher is actively retrieving data. */
gone 2016/07/23 23:39:22 Comment should be updated.
dominickn 2016/07/25 00:23:51 Done.
@VisibleForTesting
- public boolean isFetcherActiveForTesting() {
- return nativeIsFetcherActive(mNativePointer);
+ public boolean isActiveForTesting() {
+ return nativeIsActiveForTesting(mNativePointer);
}
/** Returns the AppBannerManager object. This is owned by the C++ banner manager. */
@@ -173,5 +173,5 @@ public class AppBannerManager {
private static native void nativeDisableSecureSchemeCheckForTesting();
private static native void nativeSetEngagementWeights(double directEngagement,
double indirectEngagement);
- private native boolean nativeIsFetcherActive(long nativeAppBannerManagerAndroid);
+ private native boolean nativeIsActiveForTesting(long nativeAppBannerManagerAndroid);
}

Powered by Google App Engine
This is Rietveld 408576698