WebCrypto: Add crypto.subtle.verify() to the platform interfaces.

WebCrypto: Add crypto.subtle.verify() to the platform interfaces.

BUG=245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155395

[eroman, 2013-08-01 19:59:16]

https://codereview.chromium.org/21561004/diff/9001/Source/modules/crypto/Cryp...
File Source/modules/crypto/CryptoOperation.cpp (right):

https://codereview.chromium.org/21561004/diff/9001/Source/modules/crypto/Cryp...
Source/modules/crypto/CryptoOperation.cpp:129:
promiseResolver()->fulfill(ScriptValue(b ? v8::True() : v8::False()));
Do you want me to add a boolean method to ScriptValue() instead of accessing
v8:: directly here?

[abarth-chromium, 2013-08-01 21:02:12]

lgtm

https://codereview.chromium.org/21561004/diff/9001/Source/modules/crypto/Cryp...
File Source/modules/crypto/CryptoOperation.cpp (right):

https://codereview.chromium.org/21561004/diff/9001/Source/modules/crypto/Cryp...
Source/modules/crypto/CryptoOperation.cpp:129:
promiseResolver()->fulfill(ScriptValue(b ? v8::True() : v8::False()));
On 2013/08/01 19:59:16, eroman wrote:
> Do you want me to add a boolean method to ScriptValue() instead of accessing
> v8:: directly here?

Yeah.  We should have a ScriptBoolean(bool).

[abarth-chromium, 2013-08-01 21:03:18]

Or maybe ScriptValue::createBoolean(bool) ?

[eroman, 2013-08-01 21:27:36]

Done. I went with ScriptValue::createBoolean()

[eroman, 2013-08-01 21:39:27]

I made one small change since you reviewed: renamed verify() -->
verifySignature(), because "verify" conflicts with the name of a macro on the
Mac OS build.

[commit-bot: I haz the power, 2013-08-02 00:31:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/21561004/21001

[commit-bot: I haz the power, 2013-08-02 01:14:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/21561004/34001

[commit-bot: I haz the power, 2013-08-02 05:07:10]

Change committed as 155395