Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 21555004: Scrollbar Layer revert (Closed)

Created:
7 years, 4 months ago by powei
Modified:
7 years, 4 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Scrollbar Layer using UI resource management failed webkit tests on mac/win https://chromiumcodereview.appspot.com/18191020/ https://code.google.com/p/chromium/issues/detail?id=266798 Revert back to non-UI resource. NOTRY=true TBR=aelias BUG=266798, 259095, 173947 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -225 lines) Patch
M cc/layers/scrollbar_layer.h View 3 chunks +21 lines, -7 lines 0 comments Download
M cc/layers/scrollbar_layer.cc View 7 chunks +172 lines, -76 lines 0 comments Download
M cc/layers/scrollbar_layer_impl.h View 4 chunks +8 lines, -7 lines 0 comments Download
M cc/layers/scrollbar_layer_impl.cc View 5 chunks +22 lines, -16 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 6 chunks +102 lines, -53 lines 0 comments Download
M cc/test/fake_scrollbar_layer.h View 2 chunks +8 lines, -0 lines 0 comments Download
M cc/test/fake_scrollbar_layer.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 3 chunks +11 lines, -64 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 4 months ago (2013-08-01 23:15:49 UTC) #1
aelias_OOO_until_Jul13
lgtm
7 years, 4 months ago (2013-08-01 23:17:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/powei@chromium.org/21555004/1
7 years, 4 months ago (2013-08-01 23:17:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/powei@chromium.org/21555004/1
7 years, 4 months ago (2013-08-01 23:23:29 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-02 00:13:43 UTC) #5
Message was sent while issue was closed.
Change committed as 215151

Powered by Google App Engine
This is Rietveld 408576698