cc/resources/ui_resource_request.cc - Issue 2154473004: Add a sanity DCHECK when constructing a UIResourceRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/ui_resource_request.cc

Issue 2154473004: Add a sanity DCHECK when constructing a UIResourceRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed DCHECKS on references, fixed the resource DCHECK. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/ui_resource_request.cc

diff --git a/cc/resources/ui_resource_request.cc b/cc/resources/ui_resource_request.cc

index 28fd7f3602f79ce7c558aebcd540c45e9f60749c..5d5f9a48d132bb563a3874d40eaf45e5d1436541 100644

--- a/cc/resources/ui_resource_request.cc

+++ b/cc/resources/ui_resource_request.cc

@@ -10,7 +10,9 @@ namespace cc {

UIResourceRequest::UIResourceRequest(UIResourceRequestType type,

UIResourceId id)

- : type_(type), id_(id) {}

+ : type_(type), id_(id) {

+ DCHECK(type == UIResourceRequestType::UI_RESOURCE_DELETE);

vmpstr 2016/07/15 22:10:24 nit: I don't think you need UIResourceRequestType:

Donn Denman 2016/07/15 22:15:46 Done.

UIResourceRequest::UIResourceRequest(UIResourceRequestType type,

UIResourceId id,

« no previous file with comments | « no previous file | no next file » | no next file with comments »