Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 21536003: Migrate instance of deprecated maps in HCheckMaps. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2044 matching lines...) Expand 10 before | Expand all | Expand 10 after
2055 // emit code, we will still get the register but will do an immediate 2055 // emit code, we will still get the register but will do an immediate
2056 // compare instead of the cell compare. This is safe. 2056 // compare instead of the cell compare. This is safe.
2057 LOperand* value = instr->target_in_new_space() 2057 LOperand* value = instr->target_in_new_space()
2058 ? UseRegisterAtStart(instr->value()) : UseAtStart(instr->value()); 2058 ? UseRegisterAtStart(instr->value()) : UseAtStart(instr->value());
2059 return AssignEnvironment(new(zone()) LCheckFunction(value)); 2059 return AssignEnvironment(new(zone()) LCheckFunction(value));
2060 } 2060 }
2061 2061
2062 2062
2063 LInstruction* LChunkBuilder::DoCheckMaps(HCheckMaps* instr) { 2063 LInstruction* LChunkBuilder::DoCheckMaps(HCheckMaps* instr) {
2064 LOperand* value = NULL; 2064 LOperand* value = NULL;
2065 if (!instr->CanOmitMapChecks()) value = UseRegisterAtStart(instr->value()); 2065 if (!instr->CanOmitMapChecks()) {
2066 value = UseRegisterAtStart(instr->value());
2067 if (instr->has_migration_target()) info()->MarkAsDeferredCalling();
2068 }
2066 LCheckMaps* result = new(zone()) LCheckMaps(value); 2069 LCheckMaps* result = new(zone()) LCheckMaps(value);
2067 if (instr->CanOmitMapChecks()) return result; 2070 if (!instr->CanOmitMapChecks()) {
2068 return AssignEnvironment(result); 2071 AssignEnvironment(result);
2072 if (instr->has_migration_target()) return AssignPointerMap(result);
2073 }
2074 return result;
2069 } 2075 }
2070 2076
2071 2077
2072 LInstruction* LChunkBuilder::DoClampToUint8(HClampToUint8* instr) { 2078 LInstruction* LChunkBuilder::DoClampToUint8(HClampToUint8* instr) {
2073 HValue* value = instr->value(); 2079 HValue* value = instr->value();
2074 Representation input_rep = value->representation(); 2080 Representation input_rep = value->representation();
2075 if (input_rep.IsDouble()) { 2081 if (input_rep.IsDouble()) {
2076 LOperand* reg = UseRegister(value); 2082 LOperand* reg = UseRegister(value);
2077 return DefineFixed(new(zone()) LClampDToUint8(reg), eax); 2083 return DefineFixed(new(zone()) LClampDToUint8(reg), eax);
2078 } else if (input_rep.IsInteger32()) { 2084 } else if (input_rep.IsInteger32()) {
(...skipping 657 matching lines...) Expand 10 before | Expand all | Expand 10 after
2736 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2742 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2737 LOperand* object = UseRegister(instr->object()); 2743 LOperand* object = UseRegister(instr->object());
2738 LOperand* index = UseTempRegister(instr->index()); 2744 LOperand* index = UseTempRegister(instr->index());
2739 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2745 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2740 } 2746 }
2741 2747
2742 2748
2743 } } // namespace v8::internal 2749 } } // namespace v8::internal
2744 2750
2745 #endif // V8_TARGET_ARCH_IA32 2751 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698