third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp - Issue 2153073002: Refactoring: Make some methods and fields private in Resource subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp

Issue 2153073002: Refactoring: Make some methods and fields private in Resource subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.h ('k') | third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp b/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp

index a4a649f042a9e99f5acf953cb08952bab5433567..698fe17b32f1d9e96bc1917ca9d38c27824f4abd 100644

--- a/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp

@@ -41,7 +41,7 @@ namespace blink {

class MemoryCacheTest : public ::testing::Test {

public:

- class FakeDecodedResource : public Resource {

+ class FakeDecodedResource final : public Resource {

public:

static FakeDecodedResource* create(const ResourceRequest& request, Type type)

{

@@ -54,7 +54,7 @@ public:

setDecodedSize(this->size());

}

- protected:

+ private:

FakeDecodedResource(const ResourceRequest& request, Type type, const ResourceLoaderOptions& options)

: Resource(request, type, options)

{

@@ -66,7 +66,7 @@ public:

}

};

- class FakeResource : public Resource {

+ class FakeResource final : public Resource {

public:

static FakeResource* create(const ResourceRequest& request, Type type)

{