third_party/WebKit/Source/core/fetch/FontResource.h - Issue 2153073002: Refactoring: Make some methods and fields private in Resource subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/FontResource.h

Issue 2153073002: Refactoring: Make some methods and fields private in Resource subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h ('k') | third_party/WebKit/Source/core/fetch/ImageResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/FontResource.h

diff --git a/third_party/WebKit/Source/core/fetch/FontResource.h b/third_party/WebKit/Source/core/fetch/FontResource.h

index 6b8eb95aae983ce659ba37c7f5cc144fe7f42fb7..ce8fa83bb051f6ea149a913ccd01e6e9b24f3f0b 100644

--- a/third_party/WebKit/Source/core/fetch/FontResource.h

+++ b/third_party/WebKit/Source/core/fetch/FontResource.h

@@ -62,9 +62,6 @@ public:

bool ensureCustomFontData();

FontPlatformData platformDataFromCustomData(float size, bool bold, bool italic, FontOrientation = FontOrientation::Horizontal);

-protected:

- bool isSafeToUnlock() const override;

private:

class FontResourceFactory : public ResourceFactory {

public:

@@ -82,6 +79,8 @@ private:

void fontLoadShortLimitCallback(Timer<FontResource>*);

void fontLoadLongLimitCallback(Timer<FontResource>*);

+ bool isSafeToUnlock() const override;

enum LoadLimitState { UnderLimit, ShortLimitExceeded, LongLimitExceeded };

std::unique_ptr<FontCustomPlatformData> m_fontData;