Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2153073002: Refactoring: Make some methods and fields private in Resource subclasses (Closed)

Created:
4 years, 5 months ago by hajimehoshi
Modified:
4 years, 5 months ago
Reviewers:
hiroshige, Mike West
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Make some methods and fields private in Resource subclasses This CL makes some methods and fields private in Resource subclasses to improve code health. BUG=n/a Committed: https://crrev.com/beead1d113eb5542e35040c9908077d555c74860 Cr-Commit-Position: refs/heads/master@{#405735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 739793003 Patch 60001

Messages

Total messages: 13 (7 generated)
hajimehoshi
PTAL
4 years, 5 months ago (2016-07-15 07:52:38 UTC) #4
Mike West
LGTM.
4 years, 5 months ago (2016-07-15 08:58:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153073002/1
4 years, 5 months ago (2016-07-15 09:44:36 UTC) #9
hiroshige
lgtm.
4 years, 5 months ago (2016-07-15 09:48:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 09:48:50 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 09:50:20 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/beead1d113eb5542e35040c9908077d555c74860
Cr-Commit-Position: refs/heads/master@{#405735}

Powered by Google App Engine
This is Rietveld 408576698