Prevent mouse from getting stuck on second display in login

Create an invisible window during login so that
mouse can move between displays.

Added NoSessionAshTestBase for tests that should run before
a user logs in.

BUG=266987
TEST=covered by test
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216184

[Daniel Erat, 2013-08-02 15:40:26]

lgtm

mind also updating the first line of the CL description to describe the purpose
of the change instead of the details of what you're doing?

e.g. "Prevent mouse from getting stuck on second display in login."

https://codereview.chromium.org/21519002/diff/14011/ash/root_window_controlle...
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/21519002/diff/14011/ash/root_window_controlle...
ash/root_window_controller.cc:169: class EmptyWindowDelegate : public
aura::WindowDelegate {
add a comment describing what this class is/does

https://codereview.chromium.org/21519002/diff/14011/ash/test/ash_test_helper.h
File ash/test/ash_test_helper.h (right):

https://codereview.chromium.org/21519002/diff/14011/ash/test/ash_test_helper....
ash/test/ash_test_helper.h:36: // Set |start_session| to true if the test should
run after
nit: "... if the user should log in before the test is run" would be a bit
clearer

[oshima, 2013-08-02 17:52:13]

On 2013/08/02 15:40:26, Daniel Erat wrote:
> lgtm
> 
> mind also updating the first line of the CL description to describe the
purpose
> of the change instead of the details of what you're doing?
> 
> e.g. "Prevent mouse from getting stuck on second display in login."
> 
>
https://codereview.chromium.org/21519002/diff/14011/ash/root_window_controlle...
> File ash/root_window_controller.cc (right):
> 
>
https://codereview.chromium.org/21519002/diff/14011/ash/root_window_controlle...
> ash/root_window_controller.cc:169: class EmptyWindowDelegate : public
> aura::WindowDelegate {
> add a comment describing what this class is/does
> 
> https://codereview.chromium.org/21519002/diff/14011/ash/test/ash_test_helper.h
> File ash/test/ash_test_helper.h (right):
> 
>
https://codereview.chromium.org/21519002/diff/14011/ash/test/ash_test_helper....
> ash/test/ash_test_helper.h:36: // Set |start_session| to true if the test
should
> run after
> nit: "... if the user should log in before the test is run" would be a bit
> clearer

all done.

[oshima, 2013-08-02 17:53:54]

TBRing to sky for trivial change in chrome/test/base

[commit-bot: I haz the power, 2013-08-02 17:55:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/21519002/21002

[commit-bot: I haz the power, 2013-08-02 18:04:01]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-08-02 18:07:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/21519002/21002

[commit-bot: I haz the power, 2013-08-02 19:57:51]

Retried try job too often on linux_chromeos for step(s) ash_unittests,
interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-08-02 20:47:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/21519002/51001

[commit-bot: I haz the power, 2013-08-02 20:55:02]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-08-03 03:03:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/21519002/51001

[oshima, 2013-08-03 17:37:32]

On 2013/08/03 03:03:42, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/oshima%40chromium.org/21519002/51001

Failure was real. It's actually a bug in compound_event_filter
(https://codereview.chromium.org/22051002).
I'll land this after this fix is landed.

[commit-bot: I haz the power, 2013-08-04 07:01:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/21519002/51001

[commit-bot: I haz the power, 2013-08-04 09:07:56]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-08-04 15:58:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/21519002/51001

[commit-bot: I haz the power, 2013-08-04 17:14:18]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-08-07 11:27:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/21519002/51001

[commit-bot: I haz the power, 2013-08-07 14:24:02]

Change committed as 216184