Skip posting DecodeTask of resolution changing while resetting

media/gpu/vaapi_video_decode_accelerator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/gpu/vaapi_video_decode_accelerator.h"
 
 #include <string.h>
 
 #include <memory>
 
@@ skipping 780 matching lines @@
       RETURN_AND_NOTIFY_ON_FAILURE(
           picture->Allocate(kOutputPictureFormat),
           "Failed to allocate memory for a VaapiPicture", PLATFORM_FAILURE, );
       output_buffers_.push(buffers[i].id());
     }
 
     available_va_surfaces_.push_back(va_surface_ids[i]);
     surfaces_available_.Signal();
   }
 
-  state_ = kDecoding;
-  decoder_thread_task_runner_->PostTask(
-      FROM_HERE, base::Bind(&VaapiVideoDecodeAccelerator::DecodeTask,
-                            base::Unretained(this)));
+  // The resolution changing may happen while resetting. In this case we do not
+  // change state and post DeocdeTask(). The stream will be resumed in

[Pawel Osciak, 2016/07/19 07:26:08]

s/DeocdeTask/DecodeTask/

+  // FinishReset().
+  if (state_ != kResetting) {

[Pawel Osciak, 2016/07/19 07:26:08]

Could we be in kFlushing? Should we also consider that case here?

[johnylin1, 2016/07/19 08:04:41]

Yes, I found out that the same issue may be encountered if resolution changing
event comes right between Flush() and FinishFlush(), then client will not be
notified FlushDone.

+    state_ = kDecoding;
+    decoder_thread_task_runner_->PostTask(
+        FROM_HERE, base::Bind(&VaapiVideoDecodeAccelerator::DecodeTask,
+                              base::Unretained(this)));
+  }
 }
 
 #if defined(USE_OZONE)
 static void CloseGpuMemoryBufferHandle(
     const gfx::GpuMemoryBufferHandle& handle) {
   for (const auto& fd : handle.native_pixmap_handle.fds) {
     // Close the fd by wrapping it in a ScopedFD and letting
     // it fall out of scope.
     base::ScopedFD scoped_fd(fd.fd);
   }
@@ skipping 1026 matching lines @@
   return vaapi_pic->dec_surface();
 }
 
 // static
 VideoDecodeAccelerator::SupportedProfiles
 VaapiVideoDecodeAccelerator::GetSupportedProfiles() {
   return VaapiWrapper::GetSupportedDecodeProfiles();
 }
 
 }  // namespace media