Issue 21504003: Don't assume that widgets of TYPE_CONTROL are parented to the RootWindow.

Issue 21504003: Don't assume that widgets of TYPE_CONTROL are parented to the RootWindow. (Closed)

Created:
7 years, 4 months ago by zturner

Modified:
7 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't assume that widgets of TYPE_CONTROL are parented to the RootWindow. This was causing the SadTabView to be drawn at the wrong origin. BUG=262051 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215772

Patch Set 1 #

Patch Set 2 : Add test coverage for positioning a control with a non-root parent. #

Total comments: 3

Patch Set 3 : Fix review issues. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -7 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_screen_position_client.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download
	M	ui/views/widget/desktop_aura/desktop_screen_position_client_unittest.cc	View	1 2	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/21504003/diff/6001/ui/views/widget/desktop_aura/desktop_screen_position_client_unittest.cc File ui/views/widget/desktop_aura/desktop_screen_position_client_unittest.cc (right): https://codereview.chromium.org/21504003/diff/6001/ui/views/widget/desktop_aura/desktop_screen_position_client_unittest.cc#newcode57 ui/views/widget/desktop_aura/desktop_screen_position_client_unittest.cc:57: params2.bounds = gfx::Rect(origin, gfx::Size(600,500)); nit: space after comma ...

7 years, 4 months ago (2013-08-05 21:39:15 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zturner@chromium.org/21504003/12001

7 years, 4 months ago (2013-08-05 21:53:56 UTC) #5

Message was sent while issue was closed.

Change committed as 215772

Expand Messages | Collapse Messages