Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2148183002: Refactoring: Move some Resource members from protected to private (Closed)

Created:
4 years, 5 months ago by hajimehoshi
Modified:
4 years, 5 months ago
Reviewers:
hiroshige, Mike West
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Move some Resource members from protected to private This CL moves some members from protected to private to improve code health. BUG=n/a Committed: https://crrev.com/85623f4376d86131fddb8751c10c9e9b4559a896 Cr-Commit-Position: refs/heads/master@{#405469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 3 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 739793003 Patch 60001

Messages

Total messages: 14 (5 generated)
hajimehoshi
PTAL
4 years, 5 months ago (2016-07-14 06:53:00 UTC) #2
Mike West
LGTM, thanks for the cleanup.
4 years, 5 months ago (2016-07-14 07:35:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148183002/1
4 years, 5 months ago (2016-07-14 07:38:54 UTC) #5
hiroshige
lgtm.
4 years, 5 months ago (2016-07-14 07:53:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/255714)
4 years, 5 months ago (2016-07-14 09:53:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148183002/1
4 years, 5 months ago (2016-07-14 10:04:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 11:21:16 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 11:21:32 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 11:22:35 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/85623f4376d86131fddb8751c10c9e9b4559a896
Cr-Commit-Position: refs/heads/master@{#405469}

Powered by Google App Engine
This is Rietveld 408576698