Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 21453003: Fix content_browsertests and other full stack tests in multiple_dll (Closed)

Created:
7 years, 4 months ago by scottmg
Modified:
7 years, 4 months ago
Reviewers:
joth, jam, grt (UTC plus 2)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix content_browsertests and other full stack tests in multiple_dll Tests need both sets of entry point functions, ContentClient embedder pointers, etc. Now in gyp, the three targets are content_app_browser for browser-only, content_app_child, which is child-only, and content_app_both which contains both. TBR=joth@chromium.org, grt@chromium.org R=jam@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215771

Patch Set 1 #

Patch Set 2 : shared_library #

Patch Set 3 : android4 #

Patch Set 4 : better names #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M android_webview/android_webview.gyp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 3 chunks +3 lines, -1 line 0 comments Download
M chrome/test/gpu/test_support_gpu.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/app/content_main_runner.cc View 1 2 3 4 5 chunks +7 lines, -9 lines 0 comments Download
M content/content.gyp View 1 2 3 5 chunks +19 lines, -3 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
7 years, 4 months ago (2013-08-01 02:24:57 UTC) #1
jam
lgtm
7 years, 4 months ago (2013-08-05 20:27:01 UTC) #2
scottmg
tbr: joth for rename in android_webview/ tbr: grt for rename in chrome_frame/
7 years, 4 months ago (2013-08-05 20:35:14 UTC) #3
joth
On 2013/08/05 20:35:14, scottmg wrote: > tbr: joth for rename in android_webview/ lgtm > tbr: ...
7 years, 4 months ago (2013-08-05 20:36:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/21453003/49001
7 years, 4 months ago (2013-08-05 20:37:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chrome_frame_net_tests, ...
7 years, 4 months ago (2013-08-05 21:29:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/21453003/49001
7 years, 4 months ago (2013-08-05 21:32:13 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 02:51:18 UTC) #8
Message was sent while issue was closed.
Change committed as 215771

Powered by Google App Engine
This is Rietveld 408576698