Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5329)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.h

Issue 21452002: Add metric Omnibox.FocusToOpenTime for time from omnibox focus to omnibox usage. (Closed) Base URL: https://src.chromium.org/svn/trunk/src/
Patch Set: synced Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_edit_model.h
===================================================================
--- chrome/browser/ui/omnibox/omnibox_edit_model.h (revision 215647)
+++ chrome/browser/ui/omnibox/omnibox_edit_model.h (working copy)
@@ -424,10 +424,15 @@
// autocomplete text that has not yet been accepted.
string16 user_text_;
- // We keep track of when the user last focused on the omnibox, but reset it
- // to null when user input occurs.
- base::TimeTicks last_omnibox_focus_without_user_input_;
+ // We keep track of when the user last focused on the omnibox.
+ base::TimeTicks last_omnibox_focus_;
+ // Whether any user input has occurred since focusing on the omnibox. This is
+ // used along with |last_omnibox_focus_| to calculate the time between a user
+ // focusing on the omnibox and editing. It is initialized to true since
+ // there was no focus event.
+ bool user_input_since_focus_;
+
// We keep track of when the user began modifying the omnibox text.
// This should be valid whenever user_input_in_progress_ is true.
base::TimeTicks time_user_first_modified_omnibox_;
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698