Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 21447003: Add unit tests for LatencyInfo (Closed)

Created:
7 years, 4 months ago by jbauman
Modified:
7 years, 4 months ago
Reviewers:
nduca, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add unit tests for LatencyInfo These just test same basic operations with a LatencyInfo. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215800

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -0 lines) Patch
M ui/base/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A ui/base/latency_info_unittest.cc View 1 1 chunk +142 lines, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jbauman
7 years, 4 months ago (2013-08-01 01:51:00 UTC) #1
nduca
lgtm do you think browser level tests would be useful as well? i'm thinking about ...
7 years, 4 months ago (2013-08-04 22:25:21 UTC) #2
jbauman
On 2013/08/04 22:25:21, nduca wrote: > lgtm > > do you think browser level tests ...
7 years, 4 months ago (2013-08-05 21:18:16 UTC) #3
jbauman
sky@, could you do an OWNERS review?
7 years, 4 months ago (2013-08-05 21:18:49 UTC) #4
sky
LGTM
7 years, 4 months ago (2013-08-05 23:54:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/21447003/1
7 years, 4 months ago (2013-08-06 00:02:31 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-06 00:51:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/21447003/33001
7 years, 4 months ago (2013-08-06 01:01:37 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-06 01:38:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/21447003/36003
7 years, 4 months ago (2013-08-06 02:12:14 UTC) #10
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 05:33:36 UTC) #11
Message was sent while issue was closed.
Change committed as 215800

Powered by Google App Engine
This is Rietveld 408576698