Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2144423002: [Offline Pages] Fixing bookmarking offline page will save file path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 966e0363b7f4e9df8967fa684490e223d26a2a59..39a9bbc9b8ef297a6badbb934ba96ece0ee4e3bc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -2898,6 +2898,18 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
}
/**
+ * @return Original url of the tab, if tab currently displays offline copy, would return url of
+ * the original page. Otherwise return the original url from DOMDistiller.
+ */
+ public String getOriginalUrl() {
Ian Wen 2016/07/16 01:04:54 We should convert some other places that we use ge
romax 2016/07/18 22:38:09 Done.
+ if (isOfflinePage()) {
+ return getOfflinePageOriginalUrl();
+ } else {
+ return DomDistillerUrlUtils.getOriginalUrlFromDistillerUrl(getUrl());
+ }
+ }
+
+ /**
* If a Lo-Fi snackbar has not been shown yet for this page load, a Lo-Fi snackbar is shown.
*
* @param isPreview Whether the Lo-Fi response was a preview response.
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698