chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java - Issue 2144423002: [Offline Pages] Fixing bookmarking offline page will save file path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

Issue 2144423002: [Offline Pages] Fixing bookmarking offline page will save file path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

index 1f607eff1a74c3b1e6ac11acee1d73d8b8cff04f..ad336a5020e4469de97ed325b0e38d2ecd8559b8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

@@ -33,7 +33,6 @@ import org.chromium.chrome.browser.util.FeatureUtilities;

import org.chromium.chrome.browser.util.IntentUtils;

import org.chromium.components.bookmarks.BookmarkId;

import org.chromium.components.bookmarks.BookmarkType;

-import org.chromium.components.dom_distiller.core.DomDistillerUrlUtils;

import org.chromium.ui.base.DeviceFormFactor;

/**

@@ -71,7 +70,7 @@ public class BookmarkUtils {

parent = bookmarkModel.getDefaultFolder();

}

- String url = DomDistillerUrlUtils.getOriginalUrlFromDistillerUrl(tab.getUrl());

+ String url = tab.getOriginalUrl();

BookmarkId bookmarkId = bookmarkModel.addBookmark(parent,

bookmarkModel.getChildCount(parent), tab.getTitle(), url);